Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it easier to find network modules #23576

Merged
merged 2 commits into from
Apr 13, 2017
Merged

Make it easier to find network modules #23576

merged 2 commits into from
Apr 13, 2017

Conversation

gundalow
Copy link
Contributor

SUMMARY

Feedback has been it's difficult (via Google or directly) to find
modules as some people search for the company name vs product name,
therefore specify both.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

asa_command
fortios_config

ANSIBLE VERSION
2.4.0

@gundalow
Make it easier to find network modules
ff7a8ff 
Feedback has been it's difficult (via Google or directly) to find
modules as some people search for the company name vs product name,
therefore specify both.
Qalthos
Qalthos reviewed Apr 13, 2017
View reviewed changes
lib/ansible/modules/network/iosxr/iosxr_config.py Outdated
@@ -26,7 +26,7 @@
module: iosxr_config
version_added: "2.1"
author: "Ricardo Carrillo Cruz (@rcarrillocruz)"
short_description: Manage Cisco IOS XR configuration sections
short_description: Manage Cisco IOS-XR configuration sections
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super sure, but everything I've seen seems to indicate the name is not actually hyphenated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot
hum, so it's NX-OS http://www.cisco.com/c/en/us/products/ios-nx-os-software/nx-os-software/index.html

But IOS XR http://www.cisco.com/c/en/us/support/ios-nx-os-software/ios-xr-software/tsd-products-support-series-home.html

@ansibot
Copy link
Contributor

ansibot commented Apr 13, 2017

cc @Qalthos @ganeshrn
click here for bot help

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 community_review In order to be merged, this PR must follow the community review workflow. deprecated This issue/PR relates to a deprecated module. docs_pull_request module This issue/PR relates to a module. networking Network category labels Apr 13, 2017
@ansibot ansibot assigned Qalthos and ganeshrn and unassigned Qalthos Apr 13, 2017
@ansibot
Copy link
Contributor

ansibot commented Apr 13, 2017

The test ansible-test sanity --test pylint-ansible-test failed with the following error:

Command "test/sanity/code-smell/pylint-ansible-test.sh" returned exit status 30.
>>> Standard Output
************* Module lib.changes
W: 42, 4: Useless super delegation in method '__init__' (useless-super-delegation)
************* Module lib.classification
C: 80,71: Consider iterating the dictionary directly instead of calling .keys() (consider-iterating-dictionary)
C: 94,54: Consider iterating the dictionary directly instead of calling .keys() (consider-iterating-dictionary)
************* Module lib.git
C: 87,11: Do not use `len(SEQUENCE)` as condition value (len-as-condition)
************* Module lib.import_analysis
C:113,11: Do not use `len(SEQUENCE)` as condition value (len-as-condition)
************* Module lib.executor
E:483,20: Raising SubprocessError while only classes or instances are allowed (raising-bad-type)
************* Module lib.target
R:324, 8: Unnecessary "else" after "return" (no-else-return)
************* Module lib.sanity
R: 94, 0: Disallow trailing comma tuple (trailing-comma-tuple)
E:634,32: Using variable 'SANITY_TESTS' before assignment (used-before-assignment)
W:678, 4: Useless super delegation in method '__init__' (useless-super-delegation)
************* Module lib.util
W:374, 4: Useless super delegation in method '__init__' (useless-super-delegation)
W:383, 4: Useless super delegation in method '__init__' (useless-super-delegation)
************* Module lib.test
W:195, 4: Useless super delegation in method '__init__' (useless-super-delegation)
W:214, 4: Useless super delegation in method '__init__' (useless-super-delegation)

-----------------------------------
Your code has been rated at 9.93/10

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Apr 13, 2017
@gundalow
Copy link
Contributor Author

Sam and privateip have given this the nod, so merging

The pylint errors are not related.

@gundalow gundalow merged commit 92a425a into ansible:devel Apr 13, 2017
@gundalow gundalow deleted the docs-network-titles branch April 13, 2017 16:14
gundalow added a commit to gundalow/ansible that referenced this pull request Apr 13, 2017
@gundalow
Make it easier to find network modules (ansible#23576)
2ff7364 
* Make it easier to find network modules

Feedback has been it's difficult (via Google or directly) to find
modules as some people search for the company name vs product name,
therefore specify both.

* "IOS XR" (not "IOS-XR")

(cherry picked from commit 92a425a)
@gundalow gundalow mentioned this pull request Apr 13, 2017
Merged
@gundalow
Copy link
Contributor Author

Merged into devel and temp-staging-post2.3.0 (so it will end up in stable-2.3)

abadger pushed a commit that referenced this pull request Apr 13, 2017
@gundalow @abadger
Make it easier to find network modules (#23576) (#23584)
e4d76ac 
* Make it easier to find network modules

Feedback has been it's difficult (via Google or directly) to find
modules as some people search for the company name vs product name,
therefore specify both.

* "IOS XR" (not "IOS-XR")

(cherry picked from commit 92a425a)
abadger pushed a commit that referenced this pull request Apr 13, 2017
@gundalow @abadger
Make it easier to find network modules (#23576) (#23584)
85fa2a9 
* Make it easier to find network modules

Feedback has been it's difficult (via Google or directly) to find
modules as some people search for the company name vs product name,
therefore specify both.

* "IOS XR" (not "IOS-XR")

(cherry picked from commit 92a425a)
@ansibot ansibot added docs This issue/PR relates to or includes documentation. and removed docs_pull_request labels Mar 4, 2018
@dagwieers dagwieers added fortios Fortios community asa Cisco ASA community cisco Cisco technologies labels Feb 22, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Qalthos Qalthos Qalthos left review comments

Assignees

@ganeshrn ganeshrn

Labels
affects_2.4 This issue/PR affects Ansible v2.4 asa Cisco ASA community cisco Cisco technologies deprecated This issue/PR relates to a deprecated module. docs This issue/PR relates to or includes documentation. fortios Fortios community module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. networking Network category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gundalow @ansibot @Qalthos @dagwieers @ganeshrn