Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Warning for provider #23652

Merged
merged 1 commit into from
Apr 17, 2017
Merged

Remove Warning for provider #23652

merged 1 commit into from
Apr 17, 2017

Conversation

itdependsnetworks
Copy link
Contributor

SUMMARY

Provider has a warning, I believe it should be opposite.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

junos_facts

ANSIBLE VERSION
ansible 2.3.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/etc/ntc/ansible-modules/']
  python version = 2.7.6 (default, Oct 26 2016, 20:32:47) [GCC 4.8.4]
ADDITIONAL INFORMATION
Before:
TASK [network-getters : GET JUNOS FACTS] *******************************************************************************************************************************************************************
 [WARNING]: argument provider has been deprecated and will be removed in a future version

ok: [junos-sw2]
ok: [junos-sw1]

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 bugfix_pull_request c:module_utils/ needs_triage Needs a first human triage before being processed. labels Apr 17, 2017
@gundalow gundalow added networking Network category and removed needs_triage Needs a first human triage before being processed. labels Apr 17, 2017
@gundalow gundalow added this to the 2.3.0 milestone Apr 17, 2017
ganeshrn
ganeshrn reviewed Apr 17, 2017
View reviewed changes
lib/ansible/module_utils/junos.py
@@ -44,7 +44,7 @@
def check_args(module, warnings):
provider = module.params['provider'] or {}
for key in junos_argument_spec:
if key in ('provider',) and module.params[key]:
if key not in ('provider',) and module.params[key]:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for PR. This does throw an unwanted warning for timeout argument as it has a default value in junos_argument_spec

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll ping @privateip as I believe he wanted to get rid of first level arguments, other than provider.

@ganeshrn
Copy link
Member

@itdependsnetworks I will merge the PR as this is a required change. Thank you!

@ganeshrn ganeshrn merged commit b8507b6 into ansible:devel Apr 17, 2017
ganeshrn pushed a commit to ganeshrn/ansible that referenced this pull request Apr 18, 2017
@itdependsnetworks @ganeshrn
Remove Warning for provider (ansible#23652)
b061d1a 
(cherry picked from commit b8507b6)
@ganeshrn ganeshrn mentioned this pull request Apr 18, 2017
Merged
ganeshrn added a commit that referenced this pull request Apr 18, 2017
@ganeshrn
Remove Warning for provider (#23652) (#23714)
db738e0 
(cherry picked from commit b8507b6)
@ktbyers ktbyers mentioned this pull request Apr 18, 2017
Closed
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ganeshrn ganeshrn ganeshrn left review comments

Assignees
No one assigned
Labels
affects_2.4 This issue/PR affects Ansible v2.4 bug This issue/PR relates to a bug. c:module_utils/ networking Network category
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@itdependsnetworks @ganeshrn @gundalow @ansibot