fix ansible galaxy file mangling #23703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
without this patch, ansible-galaxy will mangle files containing the archive parent directory name, eg 'owncloud/files/owncloud.cron' will become 'owncloud/files/.cron'.
ansibot
added
affects_2.4
abadger
removed
the
needs_triage
alikins
pushed a commit
that referenced
this pull request
Apr 19, 2017
without this patch, ansible-galaxy will mangle files containing the archive parent directory name, eg 'owncloud/files/owncloud.cron' will become 'owncloud/files/.cron'. The previous code could affect the entire path and even filenames. If a file path has the top level dir name as a substring, galaxy replaces it with ''. In one example, the archive top level dir is 'go', so 'files/go-bin.sh' becomes 'files/-bin.sh'. Fixes #22572, #23694, #23623 (cherry picked from commit 79943b8)
This was referenced Apr 27, 2017
ansibot
added
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
without this patch, ansible-galaxy will mangle files containing
the archive parent directory name, eg 'owncloud/files/owncloud.cron'
will become 'owncloud/files/.cron'.
this patch simply limits the replacement to the first occurence of the
archive parent directory name.
ISSUE TYPE
COMPONENT NAME
ansible-galaxy