Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eos port default values #23829

Merged
merged 3 commits into from
Apr 20, 2017
Merged

Eos port default values #23829

merged 3 commits into from
Apr 20, 2017
+8 −8

Conversation

Qalthos
Copy link
Contributor

@Qalthos Qalthos commented Apr 20, 2017

SUMMARY

Fixes #23827

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

eos

ANSIBLE VERSION
2.4

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 bugfix_pull_request c:module_utils/ c:plugins/action needs_triage Needs a first human triage before being processed. labels Apr 20, 2017
@Qalthos Qalthos added networking Network category and removed needs_triage Needs a first human triage before being processed. labels Apr 20, 2017
@Qalthos Qalthos added this to the 2.3.0 milestone Apr 20, 2017
@Qalthos Qalthos changed the title Eos values Eos port default values Apr 20, 2017
@Qalthos Qalthos merged commit 0c2a0c7 into ansible:devel Apr 20, 2017
Qalthos added a commit that referenced this pull request Apr 20, 2017
@Qalthos
Eos port default values (#23829)
c9b0026 
* Hook port back up for eos cli transport

* The default values have moved

* Why not have conditional defaults?
@Qalthos Qalthos deleted the eos_values branch April 26, 2017 18:29
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@privateip privateip privateip approved these changes

@rcarrillocruz rcarrillocruz Awaiting requested review from rcarrillocruz

Assignees
No one assigned
Labels
affects_2.4 This issue/PR affects Ansible v2.4 bug This issue/PR relates to a bug. c:module_utils/ c:plugins/action networking Network category
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

EOS cli transport ignores port
3 participants
@Qalthos @privateip @ansibot