Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional simpler json_query documentation #24041

Merged
merged 1 commit into from Sep 7, 2017
Merged

Additional simpler json_query documentation #24041

merged 1 commit into from Sep 7, 2017

Conversation

willthames
Copy link
Contributor

SUMMARY

Since json_query treats backticks as delimiters for literals,
some of the examples in the json_query docs can be made a little
simpler. Rather than replacing such examples, demonstrate the
alternative

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

plugin docs

ANSIBLE VERSION
ansible 2.4.0 (devel a5d6d3b9af) last updated 2017/04/27 09:28:12 (GMT +1000)
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/will/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/will/src/ansible/lib/ansible
  executable location = /home/will/src/ansible/bin/ansible
  python version = 2.7.13 (default, Jan 12 2017, 17:59:37) [GCC 6.3.1 20161221 (Red Hat 6.3.1-1)]

Additional simpler json_query documentation
efd656b 
Since json_query treats backticks as delimiters for literals,
some of the examples in the json_query docs can be made a little
simpler. Rather than replacing such examples, demonstrate the
alternative
@ansibot
Copy link
Contributor

ansibot commented Apr 27, 2017

cc @dharmabumstead
click here for bot help

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 docs_pull_request needs_triage Needs a first human triage before being processed. labels Apr 27, 2017
@Qalthos Qalthos removed the needs_triage Needs a first human triage before being processed. label Apr 27, 2017
@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jun 23, 2017
dharmabumstead
dharmabumstead approved these changes Sep 7, 2017
View reviewed changes
Copy link
Contributor

@dharmabumstead dharmabumstead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me. Thanks @willthames! Needs core team tech review and signoff before merge.

@dharmabumstead dharmabumstead merged commit 0d69b63 into ansible:devel Sep 7, 2017
prasadkatti pushed a commit to prasadkatti/ansible that referenced this pull request Oct 1, 2017
@willthames
Additional simpler json_query documentation (ansible#24041)
344b6fb 
Since json_query treats backticks as delimiters for literals,
some of the examples in the json_query docs can be made a little
simpler. Rather than replacing such examples, demonstrate the
alternative
@ansibot ansibot added docs This issue/PR relates to or includes documentation. and removed docs_pull_request labels Mar 4, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dharmabumstead dharmabumstead dharmabumstead approved these changes

Assignees
No one assigned
Labels
affects_2.4 This issue/PR affects Ansible v2.4 docs This issue/PR relates to or includes documentation. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@willthames @ansibot @dharmabumstead @Qalthos