Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pep8 fixes for apache2 module #24185

Merged
merged 1 commit into from May 2, 2017
Merged

Pep8 fixes for apache2 module #24185

merged 1 commit into from May 2, 2017

Conversation

Akasurde
Copy link
Member

@Akasurde Akasurde commented May 2, 2017

SUMMARY

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/web_infrastructure/apache2_mod_proxy.py
lib/ansible/modules/web_infrastructure/apache2_module.py

ANSIBLE VERSION
2.4 devel

@Akasurde
Pep8 fixes for apache2 module
0ae2f06 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansibot
Copy link
Contributor

ansibot commented May 2, 2017

cc @robinro @n0trax
click here for bot help

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 bugfix_pull_request community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. labels May 2, 2017
robinro
robinro approved these changes May 2, 2017
View reviewed changes
Copy link
Contributor

@robinro robinro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label May 2, 2017
@n0trax
Copy link
Contributor

n0trax commented May 2, 2017

shipit

1 similar comment
@robinro
Copy link
Contributor

robinro commented May 2, 2017

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels May 2, 2017
@resmo resmo merged commit 9d9e9a7 into ansible:devel May 2, 2017
@resmo
Copy link
Contributor

resmo commented May 2, 2017

Thanks all!

@Akasurde
Copy link
Member Author

Akasurde commented May 2, 2017

@resmo @robinro @n0trax Thanks.

@Akasurde Akasurde deleted the typo branch July 5, 2017 14:20
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@robinro robinro robinro approved these changes

@n0trax n0trax n0trax approved these changes

Assignees
No one assigned
Labels
affects_2.4 This issue/PR affects Ansible v2.4 bug This issue/PR relates to a bug. module This issue/PR relates to a module. shipit This PR is ready to be merged by Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Akasurde @ansibot @n0trax @robinro @resmo