Add integration test targets for core supported modules #24217

jctanner · 2017-05-02T18:35:00Z

SUMMARY

Adds a few new integration test targets for core supported modules

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

integration test targets

ANSIBLE VERSION

N/A

ADDITIONAL INFORMATION

N/A

ansibot · 2017-05-02T18:49:41Z

The test ansible-test sanity --test integration-aliases failed with the following error:

Command "test/sanity/code-smell/integration-aliases.py" returned exit status 1.
>>> Standard Output
The following integration target directories are missing `aliases` files:

test/integration/targets/raw

If these tests cannot be run as part of CI (requires external services, unsupported dependencies, etc.),
then they most likely belong in `test/integration/roles/` instead of `test/integration/targets/`.
In that case, do not add an `aliases` file. Instead, just relocate the tests.

However, if you think that the tests should be able to be supported by CI, please discuss test
organization with @mattclay or @gundalow on GitHub or #ansible-devel on IRC.

If these tests can be run as part of CI, you'll need to add an appropriate CI alias, such as:

posix/ci/group1
windows/ci/group2

The CI groups are used to balance tests across multiple jobs to minimize test run time.
Using the relevant `group1` entry is fine in most cases. Groups can be changed later to redistribute tests.

Aliases can also be used to express test requirements:

needs/privileged
needs/root
needs/ssh

Other aliases are used to skip tests under certain conditions:

skip/freebsd
skip/osx
skip/python3

Take a look at existing `aliases` files to see what aliases are available and how they're used.

The test ansible-test sanity --test yamllint failed with the following error:

test/integration/targets/raw/tasks/main.yml:83:1: too many blank lines (1 > 0) (empty-lines)

click here for bot help

ansibot · 2017-05-02T19:08:57Z

The test ansible-test sanity --test integration-aliases failed with the following error:

Command "test/sanity/code-smell/integration-aliases.py" returned exit status 1.
>>> Standard Output
The following integration target directories are missing `aliases` files:

test/integration/targets/raw

If these tests cannot be run as part of CI (requires external services, unsupported dependencies, etc.),
then they most likely belong in `test/integration/roles/` instead of `test/integration/targets/`.
In that case, do not add an `aliases` file. Instead, just relocate the tests.

However, if you think that the tests should be able to be supported by CI, please discuss test
organization with @mattclay or @gundalow on GitHub or #ansible-devel on IRC.

If these tests can be run as part of CI, you'll need to add an appropriate CI alias, such as:

posix/ci/group1
windows/ci/group2

The CI groups are used to balance tests across multiple jobs to minimize test run time.
Using the relevant `group1` entry is fine in most cases. Groups can be changed later to redistribute tests.

Aliases can also be used to express test requirements:

needs/privileged
needs/root
needs/ssh

Other aliases are used to skip tests under certain conditions:

skip/freebsd
skip/osx
skip/python3

Take a look at existing `aliases` files to see what aliases are available and how they're used.

The test ansible-test sanity --test yamllint failed with the following error:

test/integration/targets/raw/tasks/main.yml:83:1: too many blank lines (1 > 0) (empty-lines)

click here for bot help

ansibot · 2017-05-02T19:35:07Z

The test ansible-test sanity --test integration-aliases failed with the following error:

Command "test/sanity/code-smell/integration-aliases.py" returned exit status 1.
>>> Standard Output
The following integration target directories are missing `aliases` files:

test/integration/targets/raw

If these tests cannot be run as part of CI (requires external services, unsupported dependencies, etc.),
then they most likely belong in `test/integration/roles/` instead of `test/integration/targets/`.
In that case, do not add an `aliases` file. Instead, just relocate the tests.

However, if you think that the tests should be able to be supported by CI, please discuss test
organization with @mattclay or @gundalow on GitHub or #ansible-devel on IRC.

If these tests can be run as part of CI, you'll need to add an appropriate CI alias, such as:

posix/ci/group1
windows/ci/group2

The CI groups are used to balance tests across multiple jobs to minimize test run time.
Using the relevant `group1` entry is fine in most cases. Groups can be changed later to redistribute tests.

Aliases can also be used to express test requirements:

needs/privileged
needs/root
needs/ssh

Other aliases are used to skip tests under certain conditions:

skip/freebsd
skip/osx
skip/python3

Take a look at existing `aliases` files to see what aliases are available and how they're used.

The test ansible-test sanity --test yamllint failed with the following error:

test/integration/targets/raw/tasks/main.yml:83:1: too many blank lines (1 > 0) (empty-lines)

click here for bot help

ansibot · 2017-05-02T19:47:07Z

The test ansible-test sanity --test integration-aliases failed with the following error:

Command "test/sanity/code-smell/integration-aliases.py" returned exit status 1.
>>> Standard Output
The following integration target directories are missing `aliases` files:

test/integration/targets/blockinfile
test/integration/targets/raw

If these tests cannot be run as part of CI (requires external services, unsupported dependencies, etc.),
then they most likely belong in `test/integration/roles/` instead of `test/integration/targets/`.
In that case, do not add an `aliases` file. Instead, just relocate the tests.

However, if you think that the tests should be able to be supported by CI, please discuss test
organization with @mattclay or @gundalow on GitHub or #ansible-devel on IRC.

If these tests can be run as part of CI, you'll need to add an appropriate CI alias, such as:

posix/ci/group1
windows/ci/group2

The CI groups are used to balance tests across multiple jobs to minimize test run time.
Using the relevant `group1` entry is fine in most cases. Groups can be changed later to redistribute tests.

Aliases can also be used to express test requirements:

needs/privileged
needs/root
needs/ssh

Other aliases are used to skip tests under certain conditions:

skip/freebsd
skip/osx
skip/python3

Take a look at existing `aliases` files to see what aliases are available and how they're used.

The test ansible-test sanity --test yamllint failed with the following error:

test/integration/targets/raw/tasks/main.yml:83:1: too many blank lines (1 > 0) (empty-lines)

click here for bot help

ansibot · 2017-05-02T20:31:44Z

The test ansible-test sanity --test integration-aliases failed with the following error:

Command "test/sanity/code-smell/integration-aliases.py" returned exit status 1.
>>> Standard Output
The following integration target directories are missing `aliases` files:

test/integration/targets/blockinfile
test/integration/targets/find
test/integration/targets/raw

If these tests cannot be run as part of CI (requires external services, unsupported dependencies, etc.),
then they most likely belong in `test/integration/roles/` instead of `test/integration/targets/`.
In that case, do not add an `aliases` file. Instead, just relocate the tests.

However, if you think that the tests should be able to be supported by CI, please discuss test
organization with @mattclay or @gundalow on GitHub or #ansible-devel on IRC.

If these tests can be run as part of CI, you'll need to add an appropriate CI alias, such as:

posix/ci/group1
windows/ci/group2

The CI groups are used to balance tests across multiple jobs to minimize test run time.
Using the relevant `group1` entry is fine in most cases. Groups can be changed later to redistribute tests.

Aliases can also be used to express test requirements:

needs/privileged
needs/root
needs/ssh

Other aliases are used to skip tests under certain conditions:

skip/freebsd
skip/osx
skip/python3

Take a look at existing `aliases` files to see what aliases are available and how they're used.

The test ansible-test sanity --test yamllint failed with the following error:

test/integration/targets/raw/tasks/main.yml:83:1: too many blank lines (1 > 0) (empty-lines)

click here for bot help

ansibot · 2017-05-03T12:31:02Z

The test ansible-test sanity --test integration-aliases failed with the following error:

Command "test/sanity/code-smell/integration-aliases.py" returned exit status 1.
>>> Standard Output
The following integration target directories are missing `aliases` files:

test/integration/targets/blockinfile
test/integration/targets/find
test/integration/targets/iso_extract
test/integration/targets/raw

If these tests cannot be run as part of CI (requires external services, unsupported dependencies, etc.),
then they most likely belong in `test/integration/roles/` instead of `test/integration/targets/`.
In that case, do not add an `aliases` file. Instead, just relocate the tests.

However, if you think that the tests should be able to be supported by CI, please discuss test
organization with @mattclay or @gundalow on GitHub or #ansible-devel on IRC.

If these tests can be run as part of CI, you'll need to add an appropriate CI alias, such as:

posix/ci/group1
windows/ci/group2

The CI groups are used to balance tests across multiple jobs to minimize test run time.
Using the relevant `group1` entry is fine in most cases. Groups can be changed later to redistribute tests.

Aliases can also be used to express test requirements:

needs/privileged
needs/root
needs/ssh

Other aliases are used to skip tests under certain conditions:

skip/freebsd
skip/osx
skip/python3

Take a look at existing `aliases` files to see what aliases are available and how they're used.

The test ansible-test sanity --test yamllint failed with the following error:

test/integration/targets/raw/tasks/main.yml:83:1: too many blank lines (1 > 0) (empty-lines)

click here for bot help

ansibot · 2017-05-03T13:02:00Z

The test ansible-test sanity --test integration-aliases failed with the following error:

Command "test/sanity/code-smell/integration-aliases.py" returned exit status 1.
>>> Standard Output
The following integration target directories are missing `aliases` files:

test/integration/targets/apt_key
test/integration/targets/at
test/integration/targets/blockinfile
test/integration/targets/find
test/integration/targets/iso_extract
test/integration/targets/raw

If these tests cannot be run as part of CI (requires external services, unsupported dependencies, etc.),
then they most likely belong in `test/integration/roles/` instead of `test/integration/targets/`.
In that case, do not add an `aliases` file. Instead, just relocate the tests.

However, if you think that the tests should be able to be supported by CI, please discuss test
organization with @mattclay or @gundalow on GitHub or #ansible-devel on IRC.

If these tests can be run as part of CI, you'll need to add an appropriate CI alias, such as:

posix/ci/group1
windows/ci/group2

The CI groups are used to balance tests across multiple jobs to minimize test run time.
Using the relevant `group1` entry is fine in most cases. Groups can be changed later to redistribute tests.

Aliases can also be used to express test requirements:

needs/privileged
needs/root
needs/ssh

Other aliases are used to skip tests under certain conditions:

skip/freebsd
skip/osx
skip/python3

Take a look at existing `aliases` files to see what aliases are available and how they're used.

The test ansible-test sanity --test yamllint failed with the following errors:

test/integration/targets/apt_key/tasks/main.yml:30:1: too many blank lines (2 > 0) (empty-lines)
test/integration/targets/at/tasks/main.yml:62:1: too many blank lines (1 > 0) (empty-lines)
test/integration/targets/raw/tasks/main.yml:83:1: too many blank lines (1 > 0) (empty-lines)

click here for bot help

ansibot · 2017-05-03T13:13:30Z

The test ansible-test sanity --test yamllint failed with the following errors:

test/integration/targets/apt_key/tasks/main.yml:30:1: too many blank lines (2 > 0) (empty-lines)
test/integration/targets/at/tasks/main.yml:62:1: too many blank lines (1 > 0) (empty-lines)
test/integration/targets/raw/tasks/main.yml:83:1: too many blank lines (1 > 0) (empty-lines)

click here for bot help

ansibot · 2017-05-04T14:13:27Z

The test ansible-test sanity --test shellcheck failed with the following errors:

test/integration/targets/group/files/grouplist.sh:19:9: SC2002 Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
test/integration/targets/user/files/userlist.sh:19:9: SC2002 Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.

click here for bot help

ansibot · 2017-05-04T15:05:32Z

The test ansible-test sanity --test shellcheck failed with the following errors:

test/integration/targets/group/files/grouplist.sh:19:9: SC2002 Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
test/integration/targets/user/files/userlist.sh:19:9: SC2002 Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.

click here for bot help

ansibot · 2017-05-04T15:16:54Z

The test ansible-test sanity --test shellcheck failed with the following errors:

test/integration/targets/group/files/grouplist.sh:19:9: SC2002 Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
test/integration/targets/user/files/userlist.sh:19:9: SC2002 Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.

click here for bot help

ansibot · 2017-05-04T16:12:31Z

The test ansible-test sanity --test shellcheck failed with the following errors:

test/integration/targets/group/files/grouplist.sh:19:9: SC2002 Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
test/integration/targets/user/files/userlist.sh:19:9: SC2002 Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.

click here for bot help

gundalow

Thanks for doing this.

Some general comments

To test for idempotency it may be worth running state: present and state: absent twice and ensuring changed is false.

gundalow · 2017-05-09T10:31:49Z

test/integration/targets/group/files/grouplist.sh

+#  register: group_names
+#  when: 'ansible_distribution == "MacOSX"'
+
+DISTRO=$1


DISTRO="$1"
To deal with distros with spaces in, such as: openSUSE Leap

gundalow · 2017-05-09T10:32:51Z

test/integration/targets/group/files/grouplist.sh

+
+DISTRO=$1
+
+if [[ $DISTRO == "MacOSX" ]]; then


"$DISTRO"

ansibot · 2017-05-09T17:53:56Z

The test ansible-test sanity --test shellcheck failed with the following errors:

test/integration/targets/group/files/grouplist.sh:14:8: SC2124 Assigning an array to a string! Assign as array, or use * instead of @ to concatenate.
test/integration/targets/user/files/userlist.sh:14:8: SC2124 Assigning an array to a string! Assign as array, or use * instead of @ to concatenate.

click here for bot help

A preliminary set of test targets for "core" supported module that had no independent tests. These will also help us ensure python3 compatibility for those modules and prevent future regressions.

Add an integration test target for raw module

5c502d9

ansibot added affects_2.4 This issue/PR affects Ansible v2.4 feature_pull_request needs_triage Needs a first human triage before being processed. labels May 2, 2017

ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label May 2, 2017

jctanner added 2 commits May 2, 2017 14:52

Fix copyright header

73df381

Add meta file for raw test

0e2c7af

Fixup test dir name

9f08d42

Add test for blockinfile

4205925

Add test for find module

88ce2cd

gundalow self-requested a review May 3, 2017 10:28

gundalow removed the needs_triage Needs a first human triage before being processed. label May 3, 2017

Add preliminary test for iso_extract

cb30827

jctanner added 5 commits May 3, 2017 08:35

Add target for apt_key

814eb0e

Remove iso from apt test

4954e9a

Fix test tmp dir path

45049f6

Re-create iso with --no-pad

2c3e551

Add test target for at

63fcf67

Add alias files

d9acd80

jctanner added 2 commits May 3, 2017 10:29

Add test target for getent

b7e1f0e

Remove blank lines

4f055a2

jctanner added 2 commits May 4, 2017 10:57

Cleanup userlist for freebsd

d45f616

Remove blank line

28170b8

Pre-clean the test user before adding it

08ee600

Exclude comments in group script

5a427fc

ansibot added the ci_verified Changes made in this PR are causing tests to fail. label May 4, 2017

Remove 'useless' cat command

11e8c08

Ensure services all start with chars

ba045ec

ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label May 4, 2017

gundalow reviewed May 9, 2017

View reviewed changes

jctanner added 2 commits May 9, 2017 10:24

quote the distro names

d60f33b

Quote all of argv

e5524a4

ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 9, 2017

Join argv with asterisk

b848698

ansibot removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 9, 2017

gundalow approved these changes May 10, 2017

View reviewed changes

jctanner merged commit e9c2546 into ansible:devel May 10, 2017

ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 4, 2018

ansible locked and limited conversation to collaborators Apr 26, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add integration test targets for core supported modules #24217

Add integration test targets for core supported modules #24217

jctanner commented May 2, 2017

ansibot commented May 2, 2017

ansibot commented May 2, 2017

ansibot commented May 2, 2017

ansibot commented May 2, 2017

ansibot commented May 2, 2017

ansibot commented May 3, 2017

ansibot commented May 3, 2017

ansibot commented May 3, 2017

ansibot commented May 4, 2017

ansibot commented May 4, 2017

ansibot commented May 4, 2017

ansibot commented May 4, 2017

gundalow left a comment

gundalow May 9, 2017

gundalow May 9, 2017

ansibot commented May 9, 2017

Add integration test targets for core supported modules #24217

Add integration test targets for core supported modules #24217

Conversation

jctanner commented May 2, 2017

SUMMARY

ISSUE TYPE

COMPONENT NAME

ANSIBLE VERSION

ADDITIONAL INFORMATION

ansibot commented May 2, 2017

ansibot commented May 2, 2017

ansibot commented May 2, 2017

ansibot commented May 2, 2017

ansibot commented May 2, 2017

ansibot commented May 3, 2017

ansibot commented May 3, 2017

ansibot commented May 3, 2017

ansibot commented May 4, 2017

ansibot commented May 4, 2017

ansibot commented May 4, 2017

ansibot commented May 4, 2017

gundalow left a comment

Choose a reason for hiding this comment

gundalow May 9, 2017

Choose a reason for hiding this comment

gundalow May 9, 2017

Choose a reason for hiding this comment

ansibot commented May 9, 2017