nxos_vrf refactor #24280
Merged
nxos_vrf refactor #24280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trishnaguha
added
module
|
The test |
ansibot
added
WIP
trishnaguha
force-pushed
the
refactor_nxos_vrf
branch
from
2426728
to
fe1c0ee
Compare
ansibot
added
community_review
trishnaguha
force-pushed
the
refactor_nxos_vrf
branch
2 times, most recently
from
919b258
to
a5b8ecd
Compare
trishnaguha
removed
the
WIP
Qalthos
approved these changes
May 4, 2017
| @@ -139,14 +116,10 @@ def execute_show_command(command, module): | |||
|
|
|||
| def apply_key_map(key_map, table): | |||
| new_dict = {} | |||
| for key, value in table.items(): | |||
| for key in table.keys(): | |||
There was a problem hiding this comment.
I'm not sure why I did it, but there's no need for keys() here.
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
Remove unnecessary keys() method Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
trishnaguha
force-pushed
the
refactor_nxos_vrf
branch
from
ea545ed
to
bc1a38d
Compare
rcarrillocruz
approved these changes
May 5, 2017
ansibot
added
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Trishna Guha trishnaguha17@gmail.com
SUMMARY
Refactor and unit test of nxos_vrf
ISSUE TYPE
COMPONENT NAME
modules/network/nxos/nxos_vrf.pyANSIBLE VERSION