Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tower user remove organization #24544

Merged
merged 4 commits into from
May 17, 2017
Merged

Tower user remove organization #24544

merged 4 commits into from
May 17, 2017

Conversation

lshake
Copy link
Contributor

@lshake lshake commented May 12, 2017

SUMMARY

The tower-user module suggests that when adding a user it should be added to an organisation when the organization option is set on the task : "Organization the user should be made a member of." This fails and user is not made a member of the specified organisation. Fixes #24510

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

module: tower_user

ANSIBLE VERSION
ansible 2.3.0.0
  config file = /Users/xxxxxxx/.ansible.cfg
  configured module search path = Default w/o overrides
  python version = 2.7.13 (default, Mar  3 2017, 11:49:06) [GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.42.1)]
ADDITIONAL INFORMATION

Fixes issue : #24510

Removed the organization fields from the tower_user module and doc string.

@lshake lshake mentioned this pull request May 12, 2017
Closed
@ansibot
Copy link
Contributor

ansibot commented May 12, 2017

The test ansible-test sanity --test pep8 failed with the following errors:

lib/ansible/modules/web_infrastructure/ansible_tower/tower_user.py:141:22: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/ansible_tower/tower_user.py:141:24: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/ansible_tower/tower_user.py:142:21: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/ansible_tower/tower_user.py:142:23: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/ansible_tower/tower_user.py:143:23: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/ansible_tower/tower_user.py:143:25: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/ansible_tower/tower_user.py:144:22: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/ansible_tower/tower_user.py:144:24: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/ansible_tower/tower_user.py:145:21: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/ansible_tower/tower_user.py:145:23: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/ansible_tower/tower_user.py:146:18: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/ansible_tower/tower_user.py:146:20: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/ansible_tower/tower_user.py:147:22: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/ansible_tower/tower_user.py:147:24: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/ansible_tower/tower_user.py:148:20: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/ansible_tower/tower_user.py:148:22: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/ansible_tower/tower_user.py:149:23: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/ansible_tower/tower_user.py:149:25: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/ansible_tower/tower_user.py:150:27: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/ansible_tower/tower_user.py:150:29: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/ansible_tower/tower_user.py:151:27: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/ansible_tower/tower_user.py:151:29: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/ansible_tower/tower_user.py:152:29: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/ansible_tower/tower_user.py:152:31: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/ansible_tower/tower_user.py:153:30: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/ansible_tower/tower_user.py:153:32: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/ansible_tower/tower_user.py:154:18: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/ansible_tower/tower_user.py:154:20: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/web_infrastructure/ansible_tower/tower_user.py:180:37: E128 continuation line under-indented for visual indent
lib/ansible/modules/web_infrastructure/ansible_tower/tower_user.py:181:37: E128 continuation line under-indented for visual indent

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented May 12, 2017

cc @ghjm @jlaska @matburt @wwitzel3
click here for bot help

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 bugfix_pull_request ci_verified Changes made in this PR are causing tests to fail. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. labels May 12, 2017
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 12, 2017
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label May 12, 2017
matburt
matburt requested changes May 12, 2017
View reviewed changes
Copy link
Member

@matburt matburt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make that small change and it'll be fine

lib/ansible/modules/web_infrastructure/ansible_tower/tower_user.py Outdated
@@ -1,7 +1,7 @@
#!/usr/bin/python
# coding: utf-8 -*-

# (c) 2017, Wayne Witzel III <wayne@riotousliving.com>
# (c) 2017, Wayne Witzel III <wayne@riotousliving.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove added space

matburt
matburt approved these changes May 12, 2017
View reviewed changes
Copy link
Member

@matburt matburt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

wwitzel3
wwitzel3 approved these changes May 15, 2017
View reviewed changes
Copy link
Contributor

@wwitzel3 wwitzel3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@matburt
Copy link
Member

matburt commented May 16, 2017

shipit

1 similar comment
@wwitzel3
Copy link
Contributor

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels May 17, 2017
@ansibot ansibot merged commit e2c08ed into ansible:devel May 17, 2017
KKoukiou pushed a commit to KKoukiou/ansible that referenced this pull request May 22, 2017
@lshake @KKoukiou
Tower user remove organization (ansible#24544)
03a36da 
* Remove organization field from the tower_user module re: issue ansible#24510

* Fix trailing spaces.

* Fixes for Shippable errors, pep8

* Remove a random inserted space.
@ansibot ansibot added the bug This issue/PR relates to a bug. label Mar 6, 2018
@dagwieers dagwieers added the tower Tower community label Feb 8, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wwitzel3 wwitzel3 wwitzel3 approved these changes

@matburt matburt matburt approved these changes

Assignees
No one assigned
Labels
affects_2.4 This issue/PR affects Ansible v2.4 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. module This issue/PR relates to a module. shipit This PR is ready to be merged by Core tower Tower community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tower_user set organisation field has no effect.
6 participants
@lshake @ansibot @matburt @wwitzel3 @dagwieers @s-hertel