Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os_port - allow port_security_enabled boolean flag to be controlled by the module #24694

Closed
OOsemka opened this issue May 16, 2017 · 8 comments · Fixed by #47715
Closed

os_port - allow port_security_enabled boolean flag to be controlled by the module #24694

OOsemka opened this issue May 16, 2017 · 8 comments · Fixed by #47715
Labels
affects_2.2 This issue/PR affects Ansible v2.2 cloud feature This issue/PR relates to a feature request. module This issue/PR relates to a module. openstack support:community This issue/PR relates to code supported by the Ansible community.

Comments

@OOsemka
Copy link

OOsemka commented May 16, 2017

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

os_port

ANSIBLE VERSION
ansible 2.2.1.0
CONFIGURATION
OS / ENVIRONMENT

N/A

SUMMARY

The os_port ansible module currently support many parameters for creating/updating and deleting port described in here:
https://docs.ansible.com/ansible/os_port_module.html
Unfortunately port_security_enabled boolean flag is not one of the options. The defualt value is set to True.
OpenStack cli allows to set this flag as follows (example):
neutron port-update c080dbeb-491e-46e2-ab7e-192e7627d050 --port-security-enabled=False
Since my use case requires to disable the port security on only certain ports attached to the VM I am unable to automate this task with ansible.

STEPS TO REPRODUCE

the openstack CLI command to disable port-security:

neutron port-update  c080dbeb-491e-46e2-ab7e-192e7627d050 --port-security-enabled=False

No equivalent in os_port ansible module

EXPECTED RESULTS

port security disabled for created port

ACTUAL RESULTS

no way to execute that using os_port
@ansibot
Copy link
Contributor

ansibot commented May 16, 2017

cc @emonty @Shrews @juliakreger @j2sol @rcarrillocruz @Thingee
click here for bot help

@ansibot ansibot added affects_2.2 This issue/PR affects Ansible v2.2 cloud feature_idea module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. openstack labels May 16, 2017
@gundalow gundalow removed the needs_triage Needs a first human triage before being processed. label May 18, 2017
@ansibot ansibot added the support:community This issue/PR relates to code supported by the Ansible community. label Jun 29, 2017
@ansibot
Copy link
Contributor

ansibot commented Jul 18, 2017

cc @dagnello
click here for bot help

@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_idea labels Mar 2, 2018
@horacimacias horacimacias mentioned this issue Mar 28, 2018
Merged
@ansibot
Copy link
Contributor

ansibot commented May 13, 2018

cc @omgjlk
click here for bot help

@ansibot ansibot added support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed support:community This issue/PR relates to code supported by the Ansible community. labels Sep 19, 2018
@ansibot ansibot added support:community This issue/PR relates to code supported by the Ansible community. and removed support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 5, 2018
@ansibot
Copy link
Contributor

ansibot commented Oct 13, 2018

cc @mnaser
click here for bot help

@mnaser
Copy link
Contributor

mnaser commented Oct 13, 2018

FYI, as a workaround, if your entire network requires port security to be disabled, you can do so in os_network.

@mnaser
Copy link
Contributor

mnaser commented Oct 13, 2018

needs_contributor

@ansibot ansibot added the waiting_on_contributor This would be accepted but there are no plans to actively work on it. label Oct 13, 2018
@OOsemka
Copy link
Author

OOsemka commented Oct 15, 2018

I have been using shell module as a workaround. It's not optimal, but gets the job done. Being able to use single module rather then 2 would be much cleaner. Thanks for looking into it.

@MaxBab MaxBab mentioned this issue Oct 27, 2018
Merged
@ansibot
Copy link
Contributor

ansibot commented Nov 2, 2018

cc @cloudnull @evrardjp @odyssey4me
click here for bot help

@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
@sivel sivel removed the waiting_on_contributor This would be accepted but there are no plans to actively work on it. label Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
affects_2.2 This issue/PR affects Ansible v2.2 cloud feature This issue/PR relates to a feature request. module This issue/PR relates to a module. openstack support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add port_security_enabled argument to os_port module MaxBab/ansible
5 participants
@sivel @mnaser @gundalow @ansibot @OOsemka