-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternatives module: Add a check that the path to the executable exist #24800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.4
This issue/PR affects Ansible v2.4
bugfix_pull_request
community_review
In order to be merged, this PR must follow the community review workflow.
module
This issue/PR relates to a module.
needs_triage
Needs a first human triage before being processed.
labels
May 19, 2017
nitzmahone
removed
the
needs_triage
Needs a first human triage before being processed.
label
May 19, 2017
ansibot
added
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
support:community
This issue/PR relates to code supported by the Ansible community.
labels
Jun 23, 2017
This update seems unnecessary: For example:
|
@pilou- I've tested on one of our Fedora Linux instances:
|
Oops, I only checked on Debian :-/ Then this PR is useful :-) ! |
ansibot
removed
the
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
label
Aug 9, 2017
ansibot
added
the
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
label
Aug 18, 2017
rebuild_merge |
ansibot
removed
the
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
label
Aug 18, 2017
pilou-
added a commit
to pilou-/ansible
that referenced
this pull request
Aug 29, 2017
mattclay
pushed a commit
that referenced
this pull request
Sep 14, 2017
prasadkatti
pushed a commit
to prasadkatti/ansible
that referenced
this pull request
Oct 1, 2017
ansible#24800) * Add check that the path to the executable exists * Corrected a typo
prasadkatti
pushed a commit
to prasadkatti/ansible
that referenced
this pull request
Oct 1, 2017
BondAnthony
pushed a commit
to BondAnthony/ansible
that referenced
this pull request
Oct 5, 2017
ansibot
added
bug
This issue/PR relates to a bug.
and removed
bugfix_pull_request
labels
Mar 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects_2.4
This issue/PR affects Ansible v2.4
bug
This issue/PR relates to a bug.
community_review
In order to be merged, this PR must follow the community review workflow.
module
This issue/PR relates to a module.
support:community
This issue/PR relates to code supported by the Ansible community.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
By default, the alternatives tool does not verify the path to the executable that the link should point to. I've added a check that should prevent installation of requested path if the path does not exist in a system.
ISSUE TYPE
COMPONENT NAME
alternatives
ANSIBLE VERSION