Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Os port fix #24913

Merged
merged 5 commits into from
May 23, 2017
Merged

Os port fix #24913

merged 5 commits into from
May 23, 2017

Conversation

kgottholm
Copy link
Contributor

SUMMARY

cmp is not present in Python3 but several modules use it

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
ANSIBLE VERSION

ansible 2.3.0.0
config file =
configured module search path = Default w/o overrides
python version = 3.6.1 |Continuum Analytics, Inc.| (default, May 11 2017, 13:09:58) [GCC 4.4.7 20120313 (Red Hat 4.4.7-1)]


ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented May 23, 2017

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 aws bugfix_pull_request cloud module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. openstack python3 vmware VMware community labels May 23, 2017
@ansibot
Copy link
Contributor

ansibot commented May 23, 2017

@kgottholm this PR contains the following merge comits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot added merge_commit This PR contains at least one merge commit. Please resolve! and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 23, 2017
@abadger abadger merged commit 1e4b227 into ansible:devel May 23, 2017
abadger pushed a commit that referenced this pull request May 23, 2017
* replace deprecated cmp() with custom conditional
cmp is not present in Python3 but several modules use it
Reference 24756
(cherry picked from commit 1e4b227)
@abadger
Copy link
Contributor

abadger commented May 23, 2017

Merged to devel and a temp branch for eventual merging onto stable-2.3 (Not yet determined if it will be in time for 2.3.1 or 2.3.2)

abadger pushed a commit that referenced this pull request May 24, 2017
* replace deprecated cmp() with custom conditional
cmp is not present in Python3 but several modules use it
Reference 24756
(cherry picked from commit 1e4b227)
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label May 31, 2017
jimi-c pushed a commit that referenced this pull request Jun 1, 2017
* replace deprecated cmp() with custom conditional
cmp is not present in Python3 but several modules use it
Reference 24756
(cherry picked from commit 1e4b227)
@ansibot ansibot added the bug This issue/PR relates to a bug. label Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.4 This issue/PR affects Ansible v2.4 aws bug This issue/PR relates to a bug. cloud merge_commit This PR contains at least one merge commit. Please resolve! module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html openstack python3 vmware VMware community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants