Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win_environment: Added tests and return info in document #25064

Merged
merged 4 commits into from
Jun 8, 2017

Conversation

jborean93
Copy link
Contributor

SUMMARY

Adds tests for the win_environment module and also adds in the return information for this module to the docs page.

ISSUE TYPE
  • Feature Pull Request
  • Docs Pull Request
COMPONENT NAME

win_environment

ANSIBLE VERSION
ansible 2.4.0 (devel 6a3ce18e4b) last updated 2017/05/25 20:15:42 (GMT +1000)
  config file = /mnt/c/dev/module-tester/ansible.cfg
  configured module search path = [u'/home/jordan/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /mnt/c/dev/linux-ansible/lib/ansible
  executable location = /mnt/c/dev/linux-ansible/bin/ansible
  python version = 2.7.13 (default, Apr 13 2017, 08:16:29) [GCC 5.4.0 20160609]

@ansibot
Copy link
Contributor

ansibot commented May 26, 2017

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 community_review In order to be merged, this PR must follow the community review workflow. feature_pull_request module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. windows Windows community labels May 26, 2017
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. community_review In order to be merged, this PR must follow the community review workflow. and removed community_review In order to be merged, this PR must follow the community review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 26, 2017
@gundalow gundalow removed the needs_triage Needs a first human triage before being processed. label May 31, 2017
@jhawkesworth
Copy link
Contributor

Thanks for documenting return values too, surprised I missed that before.

shipit

@jhawkesworth
Copy link
Contributor

bot_status

@ansibot
Copy link
Contributor

ansibot commented Jun 8, 2017

waiting_on: maintainer
module: win_environment
supported_by: community
maintainers: jhawkesworth
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
mergeable_state: clean
shippable_status: success
maintainer_shipits: 0
community_shipits: 0
ansible_shipits: 1
shipit_actors: jhawkesworth

click here for bot help

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 8, 2017
@jborean93
Copy link
Contributor Author

No worries, I've made plenty of omissions for previous changed. I wonder if this works now that we are maintainers for all Windows things

shipit

@jhawkesworth
Copy link
Contributor

as module maintainer I think it should be enough for me too give it the ok. However the stale ci tag has appeared, which I guess might be stopping things.

Going to close and reopen to trigger CI again and see if that helps, will probably need to ship it again after.

@jhawkesworth
Copy link
Contributor

To trigger CI

@jhawkesworth jhawkesworth reopened this Jun 8, 2017
@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jun 8, 2017
@jhawkesworth
Copy link
Contributor

shipit

@jhawkesworth
Copy link
Contributor

bot_status

@ansibot
Copy link
Contributor

ansibot commented Jun 8, 2017

waiting_on: maintainer
module: win_environment
supported_by: community
maintainers: jhawkesworth
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
mergeable_state: clean
shippable_status: success
maintainer_shipits: 0
community_shipits: 1
ansible_shipits: 1
shipit_actors: jhawkesworth jborean93

click here for bot help

@dagwieers
Copy link
Contributor

shipit

@dagwieers
Copy link
Contributor

bot_status

@ansibot
Copy link
Contributor

ansibot commented Jun 8, 2017

waiting_on: maintainer
module: win_environment
supported_by: community
maintainers: jhawkesworth
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
mergeable_state: clean
shippable_status: success
maintainer_shipits: 0
community_shipits: 2
ansible_shipits: 1
shipit_actors: jhawkesworth jborean93 dagwieers

click here for bot help

@dagwieers
Copy link
Contributor

dagwieers commented Jun 8, 2017

@jhawkesworth @jborean93 It appears we are not all considered maintainers :-/
So only @jhawkesworth shipit is counting for automerge :-(

@jhawkesworth
Copy link
Contributor

Ah, I think I see what's going on here. Because I'm external commiter, I appear in 'ansible shipits' - but that seems to have stopped my 'maintainer shipit' from counting.

Just going to merge it since I can.

@jhawkesworth jhawkesworth merged commit 89caef8 into ansible:devel Jun 8, 2017
@jborean93 jborean93 deleted the win_environment-tests branch June 13, 2017 09:07
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 4, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.4 This issue/PR affects Ansible v2.4 feature This issue/PR relates to a feature request. module This issue/PR relates to a module. shipit This PR is ready to be merged by Core windows Windows community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants