rds.py: ensure port is expecting an int - fixes #24802

[s-hertel]

SUMMARY

If port is passed in as a string it won't be caught. Fixes #24802

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

lib/ansible/modules/cloud/amazon/rds.py

ANSIBLE VERSION

2.4.0

[ansibot]

The test ansible-test sanity --test validate-modules failed with the following error:

lib/ansible/modules/cloud/amazon/rds.py:0:0: E305 DOCUMENTATION.options.port.type: not a valid value for dictionary value @ data['options']['port']['type']. Got 'int'

click here for bot help

[ansibot]

cc @bpennypacker @willthames
click here for bot help

[jmcginn13]

I tested this fix locally:

• I reverted my property setting to the old one to reproduce the original error (note the extra space):
  port: "{{ database_port }} "
• I applied the patch and tested with:
  port: "bob"
  Got this error message:

argument port is of type <type 'str'> and we were unable to convert to int: invalid literal for int() with base 10: 'bob'"

Good error message!

Then back to my original value with the extra space - database successfully created with no errors even with the extra space.

[jmcginn13]

I reviewed and tested this change and it resolves the issues of ambiguous error messages for non-int ports and at the same time automatically trims off extra white space successfully converting to an int