Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New module: Add support for Arista EOS vlan (network/eos/eos_vlan) #25355

Merged
merged 8 commits into from Jun 7, 2017
Merged

New module: Add support for Arista EOS vlan (network/eos/eos_vlan) #25355

merged 8 commits into from Jun 7, 2017

Conversation

rcarrillocruz
Copy link
Contributor

@rcarrillocruz rcarrillocruz commented Jun 5, 2017 •
edited

SUMMARY

Add eos_vlan module

ISSUE TYPE
  • New module request
COMPONENT NAME

eos_vlan

ANSIBLE VERSION
ansible 2.4.0 (eos_vlan_module 240ca16d4b) last updated 2017/06/05 13:18:35 (GMT +200)

@ansibot
Copy link
Contributor

ansibot commented Jun 5, 2017

The test ansible-test sanity --test pep8 failed with the following errors:

lib/ansible/modules/network/eos/eos_vlan.py:79:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/network/eos/eos_vlan.py:93:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/network/eos/eos_vlan.py:111:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/network/eos/eos_vlan.py:118:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/network/eos/eos_vlan.py:128:13: E128 continuation line under-indented for visual indent

click here for bot help

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.4 This issue/PR affects Ansible v2.4 ci_verified Changes made in this PR are causing tests to fail. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. community_review In order to be merged, this PR must follow the community review workflow. test_pull_requests and removed ci_verified Changes made in this PR are causing tests to fail. labels Jun 5, 2017
@rcarrillocruz rcarrillocruz changed the title WIP Add eos_vlan module Add eos_vlan module Jun 5, 2017
@rcarrillocruz rcarrillocruz removed the WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. label Jun 5, 2017
@alikins alikins removed the needs_triage Needs a first human triage before being processed. label Jun 5, 2017
@alikins alikins changed the title Add eos_vlan module New module: Add support for Arista EOS vlan (network/eos/eos_vlan) Jun 5, 2017
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jun 6, 2017
ganeshrn
ganeshrn reviewed Jun 7, 2017
View reviewed changes
lib/ansible/modules/network/eos/eos_vlan.py
- name test-vlan
"""
from ansible.module_utils.basic import AnsibleModule
from ansible.module_utils.eos import load_config, run_commands
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for declarative intent modules we want to use cliconf api's?

from ansible.module_utils.connection import Connection
conn = Connection(module)
conn.load_config(cfg)

@rcarrillocruz rcarrillocruz merged commit b3e8c48 into ansible:devel Jun 7, 2017
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ganeshrn ganeshrn ganeshrn left review comments

@trishnaguha trishnaguha trishnaguha approved these changes

Assignees
No one assigned
Labels
affects_2.4 This issue/PR affects Ansible v2.4 module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rcarrillocruz @ansibot @ganeshrn @trishnaguha @alikins