Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cmdline fact uefi 23647 #25446

Merged
merged 2 commits into from
Jun 8, 2017
Merged

Cmdline fact uefi 23647 #25446

merged 2 commits into from
Jun 8, 2017

Conversation

alikins
Copy link
Contributor

@alikins alikins commented Jun 7, 2017

SUMMARY

Rebase of #23672 plus tests cases.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/module_utils/facts/system/cmdline.py

ANSIBLE VERSION
ansible 2.4.0 (cmdline_fact_uefi_23647 5c336a8f57) last updated 2017/06/07 15:00:09 (GMT -400)
  config file = 
  configured module search path = [u'/home/adrian/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/adrian/src/ansible/lib/ansible
  executable location = /home/adrian/src/ansible/bin/ansible
  python version = 2.7.13 (default, May 10 2017, 20:04:28) [GCC 6.3.1 20161221 (Red Hat 6.3.1-1)]
ADDITIONAL INFORMATION

alikins and others added 2 commits June 7, 2017 15:00
@alikins
Make CmdLineFactCollector easier to test
92c6677 
extract the parsing of the /proc/cmdline content to
_parse_proc_cmdline()

add a wrapper method for get_file_content _get_proc_cmdline()

Add unit tests of _parse_proc_cmdline based on examples
from issue #23647
@snowsky @alikins
Fix ansible_cmdline initrd fact for UEFI
5c336a8 
UEFI cmdline paths use \ path sep which would
get munged by cmdline fact collection.

Fixes #23647
@alikins alikins mentioned this pull request Jun 7, 2017
Closed
@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 bugfix_pull_request c:module_utils/ c:module_utils/facts needs_triage Needs a first human triage before being processed. labels Jun 8, 2017
@nitzmahone nitzmahone removed the needs_triage Needs a first human triage before being processed. label Jun 8, 2017
@alikins alikins merged commit f412874 into ansible:devel Jun 8, 2017
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.4 This issue/PR affects Ansible v2.4 bug This issue/PR relates to a bug. c:module_utils/facts c:module_utils/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alikins @ansibot @nitzmahone @snowsky