Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ios_static_route module #25527

Merged
merged 9 commits into from
Jun 29, 2017
Merged

Add ios_static_route module #25527

merged 9 commits into from
Jun 29, 2017

Conversation

rcarrillocruz
Copy link
Contributor

@rcarrillocruz rcarrillocruz commented Jun 9, 2017 •
edited

Add ios_static_route module

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

ios_static_route

ANSIBLE VERSION
ansible 2.4.0 (ios_static_route 934c238c04) last updated 2017/06/09 11:29:06 (GMT +200)

@rcarrillocruz rcarrillocruz changed the title ##### SUMMARY Add ios_static_route module Jun 9, 2017
@ansibot
Copy link
Contributor

ansibot commented Jun 9, 2017

The test ansible-test sanity --test ansible-doc --python 2.6 failed with the following error:

Command "ansible-doc ios_static_route" returned exit status 1.
>>> Standard Error
[ERROR]: unable to parse /root/src/github.com/ansible/ansible/lib/ansible/modu
les/network/ios/ios_static_route.py
ERROR! module ios_static_route missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 2.7 failed with the following error:

Command "ansible-doc ios_static_route" returned exit status 1.
>>> Standard Error
[ERROR]: unable to parse /root/src/github.com/ansible/ansible/lib/ansible/modu
les/network/ios/ios_static_route.py
ERROR! module ios_static_route missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.5 failed with the following error:

Command "ansible-doc ios_static_route" returned exit status 1.
>>> Standard Error
[ERROR]: unable to parse /root/src/github.com/ansible/ansible/lib/ansible/modu
les/network/ios/ios_static_route.py
ERROR! module ios_static_route missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.6 failed with the following error:

Command "ansible-doc ios_static_route" returned exit status 1.
>>> Standard Error
[ERROR]: unable to parse /root/src/github.com/ansible/ansible/lib/ansible/modu
les/network/ios/ios_static_route.py
ERROR! module ios_static_route missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test pylint failed with the following error:

lib/ansible/modules/network/ios/ios_static_route.py:139:0: syntax-error positional argument follows keyword argument

The test ansible-test sanity --test validate-modules failed with the following error:

lib/ansible/modules/network/ios/ios_static_route.py:0:0: E401 Python SyntaxError while parsing module

click here for bot help

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. labels Jun 9, 2017
@gundalow gundalow added ci_verified Changes made in this PR are causing tests to fail. and removed needs_triage Needs a first human triage before being processed. labels Jun 9, 2017
gundalow
gundalow previously requested changes Jun 15, 2017
View reviewed changes
Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor code issue. Docs and examples seem good.

What's the plan for tests for this?

lib/ansible/modules/network/ios/ios_static_route.py Outdated
argument_spec = dict(
prefix=dict(required=True, type='str'),
mask=dict(required=True, type='str'),
next_hop(required=True, type='str'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing =dict on this and the next few lines

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 23, 2017
@rcarrillocruz rcarrillocruz force-pushed the ios_static_route branch 4 times, most recently from 961f224 to 6b7cd51 Compare June 26, 2017 12:55
@ansibot ansibot added test_pull_requests and removed ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jun 26, 2017
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 27, 2017
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. community_review In order to be merged, this PR must follow the community review workflow. support:community This issue/PR relates to code supported by the Ansible community. and removed community_review In order to be merged, this PR must follow the community review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 27, 2017
trishnaguha
trishnaguha suggested changes Jun 29, 2017
View reviewed changes
lib/ansible/modules/network/ios/ios_static_route.py Outdated

if commands:
if not module.check_mode:
response = load_config(module, commands)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

load_config doesn't return anything https://github.com/ansible/ansible/blob/devel/lib/ansible/module_utils/ios.py#L121

@rcarrillocruz rcarrillocruz merged commit c8ba8bd into ansible:devel Jun 29, 2017
@dagwieers dagwieers added ios Cisco IOS community cisco Cisco technologies labels Feb 27, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trishnaguha trishnaguha trishnaguha requested changes

@gundalow gundalow gundalow left review comments

Assignees
No one assigned
Labels
affects_2.4 This issue/PR affects Ansible v2.4 cisco Cisco technologies community_review In order to be merged, this PR must follow the community review workflow. ios Cisco IOS community module This issue/PR relates to a module. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rcarrillocruz @ansibot @gundalow @trishnaguha @dagwieers