Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrects method name #25568

Merged
merged 1 commit into from
Jun 16, 2017
Merged

Corrects method name #25568

merged 1 commit into from
Jun 16, 2017

Conversation

caphrim007
Copy link
Contributor

SUMMARY

The method name was missing a 'd'. The method was not used anywhere
however, so no other code needs to be changed. Neither 'has_chilren'
nor 'has_children' are used in the codebase.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/module_utils/netcfg.py

ANSIBLE VERSION
ansible 2.4.0
  config file = 
  configured module search path = [u'/Users/trupp/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/trupp/src/envs/ansible-2.0/lib/python2.7/site-packages/ansible
  executable location = /Users/trupp/src/envs/ansible-2.0/bin/ansible
  python version = 2.7.10 (default, Feb  7 2017, 00:08:15) [GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.34)]
ADDITIONAL INFORMATION

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 bugfix_pull_request c:module_utils/ needs_triage Needs a first human triage before being processed. labels Jun 10, 2017
@ansibot
Copy link
Contributor

ansibot commented Jun 10, 2017

The test ansible-test sanity --test pep8 failed with the following error:

lib/ansible/plugins/inventory/virtualbox.py:215:1: W391 blank line at end of file

click here for bot help

@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jun 10, 2017
@caphrim007
Corrects method name
be00103 
The method name was missing a 'd'. The method was not used anywhere
however, so no other code needs to be changed. Neither 'has_chilren'
nor 'has_children' are used in the codebase.
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jun 10, 2017
@bcoca bcoca added networking Network category and removed needs_triage Needs a first human triage before being processed. labels Jun 12, 2017
@Qalthos Qalthos requested a review from privateip June 12, 2017 19:12
@gundalow gundalow merged commit 9c849d5 into ansible:devel Jun 16, 2017
@gundalow
Copy link
Contributor

Merged into devel, thanks

@caphrim007 caphrim007 deleted the bugfix.correct-method-name branch September 11, 2017 20:07
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Qalthos Qalthos Qalthos approved these changes

@gundalow gundalow gundalow approved these changes

@privateip privateip Awaiting requested review from privateip

Assignees
No one assigned
Labels
affects_2.4 This issue/PR affects Ansible v2.4 bug This issue/PR relates to a bug. c:module_utils/ networking Network category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@caphrim007 @ansibot @gundalow @Qalthos @bcoca