Added datacenter as variable to example block in vmware_guest_facts #25944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Fobhep Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information. Here are the items we could not find in your description:
Please set the description of this pullrequest with this template: |
ansibot
added
affects_2.4
Fobhep
changed the title
ryansb
removed
the
needs_triage
ansibot
added
support:community
pdellaert
reviewed
Aug 7, 2017
| @@ -63,11 +63,12 @@ | |||
| ''' | |||
|
|
|||
| EXAMPLES = ''' | |||
| - name: Gather VM facts | |||
| - name: Gather facts from standalone ESXi server having datacenter as 'ha-datacenter' | |||
| vmware_guest_facts: | |||
| hostname: 192.168.1.209 | |||
| username: administrator@vsphere.local | |||
There was a problem hiding this comment.
If this is a standalone hypervisor, shouldn't the username be root? administrator@vsphere.local is not available on a standalone hypervisor
|
@Fobhep Could you please re-word description as per ansibot suggestion ? |
ansibot
added
bugfix_pull_request
community_review
|
rebuild_merge |
ansibot
removed
the
stale_ci
prasadkatti
pushed a commit
to prasadkatti/ansible
that referenced
this pull request
Oct 1, 2017
ansibot
added
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
Bugfix Pullrequest
SUMMARY
The minimal working example should contain the "datacenter" variable, since its a required variable.
This is a fresh version of PR #23178, that I closed due to some errors in my fork.
I also included suggestions from @Akasurde
@nerzhul