Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update playbook_best_practices.rst, range notation #25959

Merged
merged 1 commit into from
Jun 22, 2017

Conversation

lvdh
Copy link

@lvdh lvdh commented Jun 21, 2017

SUMMARY

Update --limit range notation.

Current notation triggers;

"[WARNING]: Use [x:y] inclusive subscripts instead of [x-y] which has been removed"

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

Best Practices document

ANSIBLE VERSION
ansible 2.3.1.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = Default w/o overrides
  python version = 2.7.12 (default, Nov 19 2016, 06:48:10) [GCC 5.4.0 20160609]
ADDITIONAL INFORMATION

Please comment if additional information is required.

Update --limit range notation.

Current notation triggers "[WARNING]: Use [x:y] inclusive subscripts instead of [x-y] which has been removed"
@ansibot
Copy link
Contributor

ansibot commented Jun 21, 2017

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 docs_pull_request needs_triage Needs a first human triage before being processed. labels Jun 21, 2017
@lvdh
Copy link
Author

lvdh commented Jun 21, 2017

Additionally, as per http://docs.ansible.com/ansible/intro_patterns.html ranges seem to use zero-based indices now. Is it safe to assume the Pattern rules apply to --limit as well? I would happily adjust the doc further if this is the case.

@ryansb ryansb removed the needs_triage Needs a first human triage before being processed. label Jun 21, 2017
Copy link
Contributor

@dharmabumstead dharmabumstead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lvdh!

@dharmabumstead dharmabumstead merged commit 6922a18 into ansible:devel Jun 22, 2017
@lvdh lvdh deleted the patch-1 branch June 22, 2017 08:48
@ansibot ansibot added docs This issue/PR relates to or includes documentation. and removed docs_pull_request labels Mar 4, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.4 This issue/PR affects Ansible v2.4 docs This issue/PR relates to or includes documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants