Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use docker exec instead of docker cp . #26571

Merged
merged 1 commit into from
Dec 13, 2017
Merged

Conversation

xuxinkun
Copy link
Contributor

@xuxinkun xuxinkun commented Jul 10, 2017

SUMMARY

Use docker exec instead of docker cp in case some versions of docker not support cp.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

docker connection plugin

ANSIBLE VERSION
devel
ADDITIONAL INFORMATION

In some old version, docker did not support cp command. So, I use exec -i dd instead of cp to support fetch file.

@ansibot
Copy link
Contributor

ansibot commented Jul 10, 2017

@xuxinkun Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information.

Here are the items we could not find in your description:

  • issue type

Please set the description of this pullrequest with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/PULL_REQUEST_TEMPLATE.md

click here for bot help

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 c:plugins/connection/docker cloud docker needs_info This issue requires further information. Please answer any outstanding questions. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jul 10, 2017
@ansibot ansibot added bugfix_pull_request and removed needs_info This issue requires further information. Please answer any outstanding questions. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. labels Jul 10, 2017
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Jul 10, 2017
@bcoca
Copy link
Member

bcoca commented Jul 10, 2017

I would implement this as a fallback if the cp fails instead of the main way to copy files.

@xuxinkun
Copy link
Contributor Author

@bcoca OK, I modify my code. If cp fails, try to use exec instead.

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 19, 2017
@ansibot ansibot added the new_contributor This PR is the first contribution by a new community member. label Oct 18, 2017
@ansibot ansibot removed the new_contributor This PR is the first contribution by a new community member. label Nov 3, 2017
@maxamillion maxamillion self-requested a review December 13, 2017 21:03
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 13, 2017
@maxamillion maxamillion merged commit 7229eba into ansible:devel Dec 13, 2017
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.4 This issue/PR affects Ansible v2.4 bug This issue/PR relates to a bug. c:plugins/connection/docker cloud docker plugins/connection/docker support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants