Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add maintainers/botmeta version 2 #26642

Merged
merged 1 commit into from
Jul 11, 2017
Merged

Add maintainers/botmeta version 2 #26642

merged 1 commit into from
Jul 11, 2017

Conversation

jctanner
Copy link
Contributor

SUMMARY

Ansibot metadata V2

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

.github/BOTMETA.yml

ANSIBLE VERSION
devel

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 feature_pull_request needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jul 11, 2017
ryansb
ryansb approved these changes Jul 11, 2017
View reviewed changes
Copy link
Contributor

@ryansb ryansb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question: if you have a value that legitimately contains a $ how is that escaped? Can you do $$ to bypass macros?

@jctanner
Copy link
Contributor Author

The parser inside the bot is using string.Template, so I presume $$ should allow proper escaping, but I haven't tested.

@jctanner jctanner removed the needs_triage Needs a first human triage before being processed. label Jul 11, 2017
@gundalow
Copy link
Contributor

Looks good.
Once this is live I an tidy up the networking bit

@jctanner jctanner merged commit 43e5f34 into ansible:devel Jul 11, 2017
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 5, 2018
@dagwieers dagwieers added the botmeta This PR modifies the BOTMETA.yml and this requires special attention! label Feb 21, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryansb ryansb ryansb approved these changes

@gundalow gundalow gundalow approved these changes

Assignees
No one assigned
Labels
affects_2.4 This issue/PR affects Ansible v2.4 botmeta This PR modifies the BOTMETA.yml and this requires special attention! feature This issue/PR relates to a feature request. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jctanner @gundalow @ryansb @dagwieers @ansibot