Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds half-open tcp monitor module #26920

Merged

Conversation

caphrim007
Copy link
Contributor

SUMMARY

This is necessary as a part of refactoring the tcp monitor module.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

bigip_monitor_tcp_half_open

ANSIBLE VERSION
ansible 2.4.0 (feature.add-tcp-half-open-monitor 29068a7cf2) last updated 2017/07/17 12:52:15 (GMT -700)
  config file = None
  configured module search path = [u'/Users/trupp/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/trupp/src/trupp/ansible/lib/ansible
  executable location = /Users/trupp/src/trupp/ansible/bin/ansible
  python version = 2.7.10 (default, Feb  7 2017, 00:08:15) [GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.34)]
ADDITIONAL INFORMATION

Unit tests are provided. Integration tests can be found here

https://github.com/F5Networks/f5-ansible/blob/devel/test/integration/bigip_monitor_tcp_half_open.yaml#L23
https://github.com/F5Networks/f5-ansible/tree/devel/test/integration/targets/bigip_monitor_tcp_half_open/tasks

@caphrim007
Copy link
Contributor Author

#26842 requires this merge

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 needs_triage Needs a first human triage before being processed. new_plugin This PR includes a new plugin. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jul 17, 2017
@ansibot
Copy link
Contributor

ansibot commented Jul 18, 2017

@Etienne-Carriere @mryanlam @perzizzle @srvg @wojtek0806

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. networking Network category new_module This PR includes a new module. support:community This issue/PR relates to code supported by the Ansible community. labels Jul 18, 2017
@gundalow gundalow merged commit 278fa55 into ansible:devel Jul 18, 2017
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Jul 21, 2017
@caphrim007 caphrim007 deleted the feature.add-tcp-half-open-monitor branch September 11, 2017 20:06
@dagwieers dagwieers added the f5 label Sep 27, 2017
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.4 This issue/PR affects Ansible v2.4 community_review In order to be merged, this PR must follow the community review workflow. f5 module This issue/PR relates to a module. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants