Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added powershell symlink util helper #27153

Merged
merged 2 commits into from
Nov 16, 2017
Merged

added powershell symlink util helper #27153

merged 2 commits into from
Nov 16, 2017

Conversation

jborean93
Copy link
Contributor

SUMMARY

Add a SymbolicLink util helper to make it easy to create/delete and get info on symbolic links, junction points and hard links.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

Ansible.ModuleUtils.SymbolicLink

ANSIBLE VERSION
ansible 2.4.0 (powershell-symlink-util 614b18b393) last updated 2017/07/21 14:03:14 (GMT +1000)
  config file = None
  configured module search path = ['/Users/jborean/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/jborean/dev/ansible/lib/ansible
  executable location = /Users/jborean/dev/ansible/bin/ansible
  python version = 3.6.1 (default, Jul 15 2017, 12:46:28) [GCC 4.2.1 Compatible Apple LLVM 8.1.0 (clang-802.0.42)]
ADDITIONAL INFORMATION

This can be used by #23119 as well as easily fix #21048 without duplicating code.

@jborean93
Copy link
Contributor Author

@nitzmahone, feel free to make the changes for the C# code here instead of #23119. I'm hoping to get this in here and I will update the PR.

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 c:module_utils/ feature_pull_request needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 21, 2017
@s-hertel s-hertel added windows Windows community and removed needs_triage Needs a first human triage before being processed. labels Jul 21, 2017
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jul 29, 2017
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 6, 2017
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 10, 2017
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 18, 2017
@ansibot ansibot added module_utils/ needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. test This PR relates to tests. test_pull_requests labels Sep 3, 2017
@ansibot ansibot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 1, 2017
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 9, 2017
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 15, 2017
@nitzmahone
Copy link
Member

rebuild_merge

@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Nov 15, 2017
@jborean93 jborean93 merged commit 1bc4940 into ansible:devel Nov 16, 2017
@jborean93 jborean93 deleted the powershell-symlink-util branch November 16, 2017 00:12
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 5, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nitzmahone nitzmahone nitzmahone approved these changes

Assignees
No one assigned
Labels
affects_2.4 This issue/PR affects Ansible v2.4 c:module_utils/ feature This issue/PR relates to a feature request. module_utils/powershell module_utils/ needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

win_stat - symbolic and hard links not properly detected
4 participants
@jborean93 @nitzmahone @ansibot @s-hertel