feat(apt): add -f --fix-broken option to apt module

[triat]

SUMMARY

Add the option to use --fix-broken from the apt packaging system with the state: fixed

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

module/packaging/apt

ANSIBLE VERSION

ansible 2.3.1.0
  config file =
  configured module search path = Default w/o overrides
  python version = 2.7.13 (default, Dec 18 2016, 07:03:39) [GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.42.1)]

ADDITIONAL INFORMATION

[ansibot]

cc @mgwilliams
click here for bot help

[ansibot]

The test ansible-test compile --python 2.6 [?] failed with the following error:

lib/ansible/modules/packaging/os/apt.py:866:2: SyntaxError: <<<<<<< HEAD

The test ansible-test compile --python 2.7 [?] failed with the following error:

lib/ansible/modules/packaging/os/apt.py:866:2: SyntaxError: <<<<<<< HEAD

The test ansible-test compile --python 3.5 [?] failed with the following error:

lib/ansible/modules/packaging/os/apt.py:866:2: SyntaxError: <<<<<<< HEAD

The test ansible-test compile --python 3.6 [?] failed with the following error:

lib/ansible/modules/packaging/os/apt.py:866:2: SyntaxError: <<<<<<< HEAD

The test ansible-test compile --python 3.7 [?] failed with the following error:

lib/ansible/modules/packaging/os/apt.py:866:2: SyntaxError: <<<<<<< HEAD

The test ansible-test sanity --test ansible-doc --python 2.6 [?] failed with the following error:

Command "ansible-doc apt" returned exit status 1.
>>> Standard Error
ERROR! module apt missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 2.7 [?] failed with the following error:

Command "ansible-doc apt" returned exit status 1.
>>> Standard Error
ERROR! module apt missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.5 [?] failed with the following error:

Command "ansible-doc apt" returned exit status 1.
>>> Standard Error
ERROR! module apt missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.6 [?] failed with the following error:

Command "ansible-doc apt" returned exit status 1.
>>> Standard Error
ERROR! module apt missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test import --python 2.6 [?] failed with the following error:

lib/ansible/modules/packaging/os/apt.py:866:2: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 2.7 [?] failed with the following error:

lib/ansible/modules/packaging/os/apt.py:866:2: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 3.5 [?] failed with the following error:

lib/ansible/modules/packaging/os/apt.py:866:2: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 3.7 [?] failed with the following error:

lib/ansible/modules/packaging/os/apt.py:866:2: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 3.6 [?] failed with the following error:

lib/ansible/modules/packaging/os/apt.py:866:2: SyntaxError: invalid syntax

The test ansible-test sanity --test pep8 [?] failed with the following errors:

lib/ansible/modules/packaging/os/apt.py:866:1: E122 continuation line missing indentation or outdented
lib/ansible/modules/packaging/os/apt.py:866:3: E225 missing whitespace around operator
lib/ansible/modules/packaging/os/apt.py:866:5: E227 missing whitespace around bitwise or shift operator
lib/ansible/modules/packaging/os/apt.py:869:1: E122 continuation line missing indentation or outdented
lib/ansible/modules/packaging/os/apt.py:869:3: E225 missing whitespace around operator
lib/ansible/modules/packaging/os/apt.py:869:5: E225 missing whitespace around operator
lib/ansible/modules/packaging/os/apt.py:869:8: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/os/apt.py:872:1: E122 continuation line missing indentation or outdented
lib/ansible/modules/packaging/os/apt.py:872:7: E225 missing whitespace around operator
lib/ansible/modules/packaging/os/apt.py:872:25: E225 missing whitespace around operator
lib/ansible/modules/packaging/os/apt.py:872:28: E225 missing whitespace around operator
lib/ansible/modules/packaging/os/apt.py:872:32: E226 missing whitespace around arithmetic operator

The test ansible-test sanity --test pylint [?] failed with the following error:

lib/ansible/modules/packaging/os/apt.py:866:0: syntax-error invalid syntax (<string>, line 866)

The test ansible-test sanity --test validate-modules [?] failed with the following error:

lib/ansible/modules/packaging/os/apt.py:0:0: E401 Python SyntaxError while parsing module

click here for bot help

[triat]

Hey, do I need to do something more to the PR? Let me know if I can help you to integrate it easily. Thanks

[maxamillion]

@triat Thank you for the pull request! Apologies for the lag time on this, I'm currently going through the queue and trying to clean up stale PRs. I think the change looks fine but I would like to have some integration test(s) included. Thanks again.

[triat]

Hey @maxamillion! Don't worry, when I saw the 1600~ PR waiting, I was not expecting a quick answer. Thanks for taking the time to review this one, I'll make the test(s) ASAP.

[maxamillion]

@triat greatly appreciated, thanks again! :)

[mattclay]

CI failure in integration tests: https://app.shippable.com/github/ansible/ansible/runs/85811/39/tests

[triat]

Hey @mattclay,I just rebased on devel, pushed to upgrade the PR and saw it was not passing anymore. I have to check but I hadn't the time right now to figure out why I can not run the test on my mac (also in a linux VM as I saw that it is recommended to run the tests on a linux OS)

[mattclay]

@triat If you have Docker installed on your Mac you can run the test from your branch with:

bin/ansible-test integration apt --docker ubuntu1604 -v

[mattclay]

The tests are failing because state_fixed is undefined when p['state'] != 'fixed'.

[triat]

thanks for the check, that's actually pretty obvious looking at the code I've made!

[triat]

I've been trying this command but I don't know what I've done to get it wrong. I ran it again and it was magically properly failing. Anyway, thanks again for the help, I've fixed the initialization and I'll have to write a test now.

Regarding this part, is there any recommendation if I need to install something with dpkg which will miss some dependencies that I'll then install through apt -f ?

[maxamillion]

rebuild_merge