Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stops trying to filter out commands from config #28002

Merged
merged 2 commits into from
Aug 10, 2017
Merged

stops trying to filter out commands from config #28002

merged 2 commits into from
Aug 10, 2017

Conversation

privateip
Copy link
Contributor

fixes #24874

@ansibot
Copy link
Contributor

ansibot commented Aug 10, 2017

@privateip Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information.

Here are the items we could not find in your description:

  • issue type

Please set the description of this pullrequest with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/PULL_REQUEST_TEMPLATE.md

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 10, 2017

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 module This issue/PR relates to a module. needs_info This issue requires further information. Please answer any outstanding questions. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. needs_triage Needs a first human triage before being processed. networking Network category owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Aug 10, 2017
@ansibot
Copy link
Contributor

ansibot commented Aug 10, 2017

The test ansible-test sanity --test ansible-doc --python 2.6 failed with the following error:

Command "ansible-doc sros_config" returned exit status 1.
>>> Standard Error
[ERROR]: unable to parse /root/src/github.com/ansible/ansible/lib/ansible/modu
les/network/sros/sros_config.py
ERROR! module sros_config missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 2.7 failed with the following error:

Command "ansible-doc sros_config" returned exit status 1.
>>> Standard Error
[ERROR]: unable to parse /root/src/github.com/ansible/ansible/lib/ansible/modu
les/network/sros/sros_config.py
ERROR! module sros_config missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.5 failed with the following error:

Command "ansible-doc sros_config" returned exit status 1.
>>> Standard Error
[ERROR]: unable to parse /root/src/github.com/ansible/ansible/lib/ansible/modu
les/network/sros/sros_config.py
ERROR! module sros_config missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.6 failed with the following error:

Command "ansible-doc sros_config" returned exit status 1.
>>> Standard Error
[ERROR]: unable to parse /root/src/github.com/ansible/ansible/lib/ansible/modu
les/network/sros/sros_config.py
ERROR! module sros_config missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test import --python 2.6 failed with the following error:

lib/ansible/modules/network/sros/sros_config.py:213:0: SyntaxError: trailing comma not allowed without surrounding parentheses

The test ansible-test sanity --test import --python 2.7 failed with the following error:

lib/ansible/modules/network/sros/sros_config.py:213:0: SyntaxError: trailing comma not allowed without surrounding parentheses

The test ansible-test sanity --test import --python 3.5 failed with the following error:

lib/ansible/modules/network/sros/sros_config.py:213:38: SyntaxError: trailing comma not allowed without surrounding parentheses

The test ansible-test sanity --test import --python 3.6 failed with the following error:

lib/ansible/modules/network/sros/sros_config.py:213:38: SyntaxError: trailing comma not allowed without surrounding parentheses

The test ansible-test sanity --test pylint failed with the following error:

lib/ansible/modules/network/sros/sros_config.py:213:0: syntax-error trailing comma not allowed without surrounding parentheses

The test ansible-test sanity --test validate-modules failed with the following error:

lib/ansible/modules/network/sros/sros_config.py:0:0: E401 Python SyntaxError while parsing module

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 10, 2017
@privateip privateip merged commit c4da612 into ansible:devel Aug 10, 2017
@privateip privateip deleted the fix-24874 branch August 10, 2017 13:18
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Aug 11, 2017
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.4 This issue/PR affects Ansible v2.4 module This issue/PR relates to a module. needs_info This issue requires further information. Please answer any outstanding questions. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. networking Network category owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sros_config does not run commands correctly in Ansible 2.3
3 participants