Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect bool check in Pure Storage modules #28007

Merged
merged 1 commit into from
Aug 17, 2017
Merged

Fix incorrect bool check in Pure Storage modules #28007

merged 1 commit into from
Aug 17, 2017

Conversation

sdodsley
Copy link
Contributor

SUMMARY

Fix an incorrect interpretation of a bool variable.
Wasn't taking notice of the eradicate requests

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

modules/storage/purestorage

ANSIBLE VERSION
ansible 2.4.0 (devel 1fb1793c70) last updated 2017/08/08 08:07:53 (GMT -700)
  config file = None
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /root/ansible/lib/ansible
  executable location = /root/ansible/bin/ansible
  python version = 2.7.5 (default, Nov  6 2016, 00:28:07) [GCC 4.8.5 20150623 (Red Hat 4.8.5-11)]
ADDITIONAL INFORMATION

Type of bool was incorrectly being checked in if statement.
Corrected to use appropriate syntax

@ansibot
Copy link
Contributor

ansibot commented Aug 10, 2017

cc @simondodsley
click here for bot help

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 bugfix_pull_request community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Aug 10, 2017
@ansibot
Copy link
Contributor

ansibot commented Aug 10, 2017

The test ansible-test sanity --test pep8 failed with the following errors:

lib/ansible/modules/storage/purestorage/purefa_pg.py:165:39: E712 comparison to True should be 'if cond is True:' or 'if cond:'
lib/ansible/modules/storage/purestorage/purefa_volume.py:144:39: E712 comparison to True should be 'if cond is True:' or 'if cond:'

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Aug 10, 2017
@sdodsley
Fix incorrect bool check in Pure Storage modules
95101a9 
bool was not being correctly interpreted. Fix to ensure
it does what it is supposed to.
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 10, 2017
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Aug 10, 2017
@sdodsley
Copy link
Contributor Author

:shipit:

@jctanner jctanner mentioned this pull request Aug 17, 2017
Closed
@abadger abadger merged commit e7b0849 into ansible:devel Aug 17, 2017
@abadger
Copy link
Contributor

abadger commented Aug 17, 2017

Merged to devel for 2.4 release. Thanks @sdodsley

@sdodsley sdodsley deleted the purefa_bool_fix branch August 17, 2017 21:46
prasadkatti pushed a commit to prasadkatti/ansible that referenced this pull request Oct 1, 2017
@sdodsley
Fix incorrect bool check in Pure Storage modules (ansible#28007)
b63feb3
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.4 This issue/PR affects Ansible v2.4 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sdodsley @ansibot @abadger @samdoran