Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACI Filter Entry: New Module #28200

Merged
merged 2 commits into from Aug 15, 2017
Merged

ACI Filter Entry: New Module #28200

merged 2 commits into from Aug 15, 2017

Conversation

jmcgill298
Copy link
Contributor

SUMMARY

New Module: Add support for managing Filter Entries in ACI

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

aci_filter_entry

ANSIBLE VERSION
2.4
ADDITIONAL INFORMATION

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. labels Aug 15, 2017
@dagwieers dagwieers self-requested a review August 15, 2017 00:46
@ansibot
Copy link
Contributor

ansibot commented Aug 15, 2017

The test ansible-test sanity --test validate-modules failed with the following errors:

lib/ansible/modules/network/aci/aci_filter_entry.py:0:0: E305 DOCUMENTATION.options.description.alias: extra keys not allowed @ data['options']['description']['alias']. Got ['descr']
lib/ansible/modules/network/aci/aci_filter_entry.py:0:0: E305 DOCUMENTATION.options.tenant.alias: extra keys not allowed @ data['options']['tenant']['alias']. Got ['tenant_name']

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Aug 15, 2017
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Aug 15, 2017
@ansibot
Copy link
Contributor

ansibot commented Aug 15, 2017

@jmcgill298 @schunduri

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 15, 2017
@dagwieers dagwieers merged commit 24ec04c into ansible:devel Aug 15, 2017
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Aug 16, 2017
@jmcgill298 jmcgill298 deleted the filter_entry branch August 24, 2017 18:53
@dagwieers dagwieers added the aci Cisco ACI community label Sep 27, 2017
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dagwieers dagwieers dagwieers approved these changes

Assignees
No one assigned
Labels
aci Cisco ACI community affects_2.4 This issue/PR affects Ansible v2.4 cisco Cisco technologies community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jmcgill298 @ansibot @dagwieers @samdoran