Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win_domain_membership: Fix the reboot_required return value #28579

Merged
merged 1 commit into from
Aug 24, 2017
Merged

win_domain_membership: Fix the reboot_required return value #28579

merged 1 commit into from
Aug 24, 2017

Conversation

dagwieers
Copy link
Contributor

@dagwieers dagwieers commented Aug 23, 2017 •
edited

SUMMARY

This fixes #28565

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_domain_membership

ANSIBLE VERSION

v2.4

@ansibot
Copy link
Contributor

ansibot commented Aug 23, 2017

cc @jborean93 @jhawkesworth @nitzmahone
click here for bot help

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 bugfix_pull_request core_review In order to be merged, this PR must follow the core review workflow. labels Aug 23, 2017
@dagwieers dagwieers changed the title Fix the reboot_required return value win_domain_membership: Fix the reboot_required return value Aug 23, 2017
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community labels Aug 23, 2017
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Aug 24, 2017
@jborean93 jborean93 merged commit d830186 into ansible:devel Aug 24, 2017
@dagwieers dagwieers mentioned this pull request Sep 8, 2017
Closed
prasadkatti pushed a commit to prasadkatti/ansible that referenced this pull request Oct 1, 2017
@dagwieers
Fix the reboot_required return value (ansible#28579)
2f6c07f 
As reported in ansible#28565
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nitzmahone nitzmahone Awaiting requested review from nitzmahone

@jborean93 jborean93 Awaiting requested review from jborean93

Assignees
No one assigned
Labels
affects_2.4 This issue/PR affects Ansible v2.4 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reboot always required executing win_domain_membership
4 participants
@dagwieers @ansibot @bcoca @jborean93