Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

less confusing 'args' message #29053

Merged
merged 3 commits into from
Sep 6, 2017
Merged

less confusing 'args' message #29053

merged 3 commits into from
Sep 6, 2017

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Sep 6, 2017

SUMMARY

title says all

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

core

ANSIBLE VERSION
2.4

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 bugfix_pull_request needs_triage Needs a first human triage before being processed. playbook/base support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 6, 2017
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Sep 6, 2017
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Sep 6, 2017
@ansible ansible deleted a comment from ansibot Sep 6, 2017
@mattclay
Copy link
Member

mattclay commented Sep 6, 2017

CI failure in unit tests:

>       self.assertRaisesRegexp(AnsibleParserError, exc_regex_str, self._base_validate, ds)
E       AssertionError: "test_attr_example.*which appears to include a variable that is undefined.*some_var_that_shouldnt" does not match "The field 'test_attr_example' has an invalid value, which includes an undefined variable. The error was: 'some_var_that_shouldnt_exist_to_test_omit' is undefined
E       exception type: <class 'ansible.errors.AnsibleUndefinedVariable'>
E       exception: 'some_var_that_shouldnt_exist_to_test_omit' is undefined"

test/units/playbook/test_base.py:534: AssertionError

@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Sep 6, 2017
@ansibot
Copy link
Contributor

ansibot commented Sep 6, 2017

The test ansible-test sanity --test pylint [?] failed with the following error:

lib/ansible/playbook/base.py:450:29: too-many-format-args Too many arguments for format string

click here for bot help

@ansibot ansibot added test This PR relates to tests. test_pull_requests and removed ci_verified Changes made in this PR are causing tests to fail. labels Sep 6, 2017
@ansibot
Copy link
Contributor

ansibot commented Sep 6, 2017

The test ansible-test sanity --test pylint [?] failed with the following error:

lib/ansible/playbook/base.py:450:29: too-many-format-args Too many arguments for format string

click here for bot help

@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Sep 6, 2017
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Sep 6, 2017
@bcoca bcoca modified the milestone: 2.4.0 Sep 6, 2017
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Sep 6, 2017
@bcoca bcoca merged commit fe3b432 into ansible:devel Sep 6, 2017
@bcoca bcoca deleted the args_error_fix branch September 6, 2017 22:20
abadger pushed a commit that referenced this pull request Sep 6, 2017
@bcoca @abadger
less confusing 'args' message (#29053)
5ce6066 
* less confusing 'args' message

* fix test

* gone native

(cherry picked from commit fe3b432)
bcoca added a commit that referenced this pull request Sep 6, 2017
@bcoca
less confusing 'args' message (#29053)
7787ed2 
* less confusing 'args' message
* fix test

(cherry picked from commit fe3b432)
prasadkatti pushed a commit to prasadkatti/ansible that referenced this pull request Oct 1, 2017
@bcoca
less confusing 'args' message (ansible#29053)
933be6b 
* less confusing 'args' message

* fix test

* gone native
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.4 This issue/PR affects Ansible v2.4 bug This issue/PR relates to a bug. playbook/base support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bcoca @mattclay @ansibot