Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACI EPG TO DOMAIN: Add vm_provider docstring and add support for micr… #29114

Merged
merged 3 commits into from
Sep 12, 2017
Merged

ACI EPG TO DOMAIN: Add vm_provider docstring and add support for micr… #29114

merged 3 commits into from
Sep 12, 2017

Conversation

jmcgill298
Copy link
Contributor

…osoft and openstack

SUMMARY
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

aci_epg_to_domain

ANSIBLE VERSION
2.4
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Sep 7, 2017

cc @dagwieers @schunduri
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 community_review In order to be merged, this PR must follow the community review workflow. feature_pull_request module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Sep 7, 2017
@ansibot
Copy link
Contributor

ansibot commented Sep 7, 2017

The test ansible-test sanity --test pep8 [?] failed with the following error:

lib/ansible/modules/network/aci/aci_epg_to_domain.py:131:47: E201 whitespace after '['

The test ansible-test sanity --test validate-modules [?] failed with the following error:

lib/ansible/modules/network/aci/aci_epg_to_domain.py:0:0: E309 version_added for new option (vm_provider) should be 2.5. Currently 0.0

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Sep 7, 2017
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Sep 8, 2017
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. labels Sep 8, 2017
@ansibot
Copy link
Contributor

ansibot commented Sep 8, 2017

The test ansible-test sanity --test validate-modules [?] failed with the following error:

lib/ansible/modules/network/aci/aci_epg_to_domain.py:0:0: E309 version_added for new option (vm_provider) should be 2.5. Currently 0.0

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Sep 8, 2017
@gundalow gundalow merged commit 2489eee into ansible:devel Sep 12, 2017
@abadger
Copy link
Contributor

abadger commented Sep 12, 2017

Cherrypicked to stable-2.4 for 2.4.0rc3

abadger pushed a commit that referenced this pull request Sep 12, 2017
@jmcgill298 @abadger
ACI EPG TO DOMAIN: Add vm_provider docstring and add support for micr… (
f13bf98 
#29114)

* ACI EPG TO DOMAIN: Add vm_provider docstring and add support for microsoft and openstack

* Fix typo

* Fix whitespace

(cherry picked from commit 2489eee)
@dagwieers dagwieers added the aci Cisco ACI community label Sep 27, 2017
prasadkatti pushed a commit to prasadkatti/ansible that referenced this pull request Oct 1, 2017
@jmcgill298
ACI EPG TO DOMAIN: Add vm_provider docstring and add support for micr… (
cf3a9d2 
ansible#29114)

* ACI EPG TO DOMAIN: Add vm_provider docstring and add support for microsoft and openstack

* Fix typo

* Fix whitespace
BondAnthony pushed a commit to BondAnthony/ansible that referenced this pull request Oct 5, 2017
@jmcgill298 @BondAnthony
ACI EPG TO DOMAIN: Add vm_provider docstring and add support for micr… (
2ae772c 
ansible#29114)

* ACI EPG TO DOMAIN: Add vm_provider docstring and add support for microsoft and openstack

* Fix typo

* Fix whitespace
@jmcgill298 jmcgill298 deleted the epg_domain branch December 11, 2017 04:09
@jmcgill298 jmcgill298 mentioned this pull request Dec 17, 2017
Closed
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 5, 2018
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
aci Cisco ACI community affects_2.5 This issue/PR affects Ansible v2.5 ci_verified Changes made in this PR are causing tests to fail. cisco Cisco technologies feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. networking Network category owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jmcgill298 @ansibot @abadger @dagwieers @gundalow @samdoran