-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NetApp E-Series Auth - Resolve issues with validate_certs and error handling #30167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The E-Series auth module was using some erronous behavior on handling the status codes when updating the system password. This patch resolves some of these issues.
The auth module was ignoring the validate_certs parameter for making HTTPS calls to the back-end API. This patch resolves the ignored parameter.
ansibot
added
affects_2.5
This issue/PR affects Ansible v2.5
bugfix_pull_request
community_review
In order to be merged, this PR must follow the community review workflow.
module
This issue/PR relates to a module.
needs_triage
Needs a first human triage before being processed.
owner_pr
This PR is made by the module's maintainer.
support:community
This issue/PR relates to code supported by the Ansible community.
labels
Sep 12, 2017
shipit |
ansibot
added
automerge
This PR was automatically merged by ansibot.
shipit
This PR is ready to be merged by Core
and removed
community_review
In order to be merged, this PR must follow the community review workflow.
needs_triage
Needs a first human triage before being processed.
labels
Sep 12, 2017
This message was created automatically by mail delivery software.
A message that you sent could not be delivered to one or more of its
recipients. This is a temporary error. The following address(es) deferred:
acmeideal@gmail.com
Domain biomassiv.es has exceeded the max emails per hour (100/100 (100%)) allowed. Message will be reattempted later
…------- This is a copy of the message, including all the headers. ------
Received: from github-smtp2-ext5.iad.github.net ([192.30.252.196]:47283 helo=github-smtp2a-ext-cp1-prd.iad.github.net)
by chi-server32.websitehostserver.net with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
(Exim 4.89)
(envelope-from <noreply@github.com>)
id 1drrFq-0031Hq-Cj
for greg@biomassiv.es; Tue, 12 Sep 2017 14:53:54 -0500
Date: Tue, 12 Sep 2017 12:53:14 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com;
s=pf2014; t=1505245994;
bh=PVwxs9oXzX26FjWeVUt0fo7oX2DhDiNHi5FU/JzCnFg=;
h=From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID:
List-Archive:List-Post:List-Unsubscribe:From;
b=K/7TNsuMbMNvN31TLlkQ8hxAG9SGosS8GiljUvYwr8RfehQsbVAqPqP0HijH3vdAs
fcBersk1C/5snQDJeLjwn9lg2m752i+rv1szoTcwzbr+ppuj+riJjxctYC3wdhML3V
fvVs1XJM6WrQ4by5YNOL5YyDyi8Qd0taynQWXFyk=
From: ansibot <notifications@github.com>
Reply-To: ansible/ansible <reply@reply.github.com>
To: ansible/ansible <ansible@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <ansible/ansible/pull/30167/issue_event/1245985026@github.com>
In-Reply-To: <ansible/ansible/pull/30167@github.com>
References: <ansible/ansible/pull/30167@github.com>
Subject: Re: [ansible/ansible] NetApp E-Series Auth - Resolve issues with
validate_certs and error handling (#30167)
Mime-Version: 1.0
Content-Type: multipart/alternative;
boundary="--==_mimepart_59b83b2a6a558_48903fcd3a009c3081478";
charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ansibot
X-GitHub-Recipient: biomassives
X-GitHub-Reason: subscribed
List-ID: ansible/ansible <ansible.ansible.github.com>
List-Archive: https://github.com/ansible/ansible
List-Post: <mailto:reply@reply.github.com>
List-Unsubscribe: <mailto:unsub+0042d4e2361beacfd90dcb34f126505ec93f4b67946052dc92cf0000000115cffd2a92a169ce0f53752e@reply.github.com>,
<https://github.com/notifications/unsubscribe/AELU4tMtAkBR2k-bCLEk28uoKuZeNoLdks5shuEqgaJpZM4PVBAb>
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: greg@biomassiv.es
----==_mimepart_59b83b2a6a558_48903fcd3a009c3081478
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Merged #30167.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#30167 (comment)
----==_mimepart_59b83b2a6a558_48903fcd3a009c3081478
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit
<p>Merged <a href="#30167" class="issue-link js-issue-link" data-url="#30167" data-id="257127726" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#30167</a>.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="#30167 (comment)">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AELU4r6oQ0XR584v3-zKzfM3-U3mTC_hks5shuEqgaJpZM4PVBAb">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AELU4v6H26qaSbSDyduYtjN8neMOe69pks5shuEqgaJpZM4PVBAb.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="#30167 (comment)"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/ansible/ansible","title":"ansible/ansible","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/ansible/ansible"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Merged #30167."}],"action":{"name":"View Pull Request","url":"#30167 (comment)"}}}</script>
----==_mimepart_59b83b2a6a558_48903fcd3a009c3081478--
|
prasadkatti
pushed a commit
to prasadkatti/ansible
that referenced
this pull request
Oct 1, 2017
…andling (ansible#30167) * Cleanup password error handling for E-Series auth The E-Series auth module was using some erronous behavior on handling the status codes when updating the system password. This patch resolves some of these issues. * Fix validate_certs param in E-Series auth module The auth module was ignoring the validate_certs parameter for making HTTPS calls to the back-end API. This patch resolves the ignored parameter.
BondAnthony
pushed a commit
to BondAnthony/ansible
that referenced
this pull request
Oct 5, 2017
…andling (ansible#30167) * Cleanup password error handling for E-Series auth The E-Series auth module was using some erronous behavior on handling the status codes when updating the system password. This patch resolves some of these issues. * Fix validate_certs param in E-Series auth module The auth module was ignoring the validate_certs parameter for making HTTPS calls to the back-end API. This patch resolves the ignored parameter.
ansibot
added
bug
This issue/PR relates to a bug.
and removed
bugfix_pull_request
labels
Mar 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects_2.5
This issue/PR affects Ansible v2.5
automerge
This PR was automatically merged by ansibot.
bug
This issue/PR relates to a bug.
module
This issue/PR relates to a module.
owner_pr
This PR is made by the module's maintainer.
shipit
This PR is ready to be merged by Core
support:community
This issue/PR relates to code supported by the Ansible community.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This patch results a few issues with the auth module. First of all, it adds in support for the validate_certs parameter where it was missing. Next it resolves a few issues with the error handling when the user chooses to update the password using the module.
If you are fixing an existing issue, please include "Fixes #nnn" in your
commit message and your description; but you should still explain what
the change does.
-->
ISSUE TYPE
COMPONENT NAME
netapp_e_auth
ANSIBLE VERSION
ADDITIONAL INFORMATION
N/A