Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a quick summary of stuff, separated by commit.
I've made some changes to the way the stats stuff is collected. Originally it would try to poll the riak stats at http://ip/stats:8098 and then fall back to running riak-admin status. I've simplified it:
Now it will attempt to poll http://ip/stats:8098 in a loop for 120 seconds (it really should never take this long, all of my work shows it coming up immediately), and if it takes longer than that, the module will fail.
Additionally I've made changes to the wait_for_handoffs and wait_for_ring, so that you can specify an integer in seconds rather than a boolean in the playbook.