Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken LimitExceeded check in iam_managed_policy #30537

Merged
merged 1 commit into from
Sep 20, 2017
Merged

Fix broken LimitExceeded check in iam_managed_policy #30537

merged 1 commit into from
Sep 20, 2017

Conversation

willthames
Copy link
Contributor

SUMMARY

When policy versions exceed 5, we hit LimitExceeded. However,
the exception checking should use e.response['Error']['Code']

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

iam_managed_policy

ANSIBLE VERSION
ansible 2.5.0 (devel 5aebcd4f7f) last updated 2017/09/19 12:22:40 (GMT +1000)
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/will/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/will/src/ansible/lib/ansible
  executable location = /home/will/src/ansible/bin/ansible
  python version = 2.7.13 (default, Sep  5 2017, 08:53:59) [GCC 7.1.1 20170622 (Red Hat 7.1.1-3)]
ADDITIONAL INFORMATION

Please backport to stable-2.4

Fix broken LimitExceeded check in iam_managed_policy
af165f5 
When policy versions exceed 5, we hit LimitExceeded. However,
the exception checking should use `e.response['Error']['Code']`
@ansibot
Copy link
Contributor

ansibot commented Sep 19, 2017

cc @dkhenry
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 aws bugfix_pull_request cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Sep 19, 2017
@s-hertel s-hertel merged commit 1858229 into ansible:devel Sep 20, 2017
s-hertel pushed a commit to s-hertel/ansible that referenced this pull request Sep 20, 2017
@willthames @s-hertel
Fix broken LimitExceeded check in iam_managed_policy (ansible#30537)
c0df60e 
When policy versions exceed 5, we hit LimitExceeded. However,
the exception checking should use `e.response['Error']['Code']`
@s-hertel s-hertel mentioned this pull request Sep 20, 2017
Merged
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Sep 20, 2017
ryansb pushed a commit that referenced this pull request Sep 21, 2017
@s-hertel @ryansb
[cloud] Fix broken LimitExceeded check in iam_managed_policy (#30537) (…
2fca9d5 
…#30626)

When policy versions exceed 5, we hit LimitExceeded. However,
the exception checking should use `e.response['Error']['Code']`
prasadkatti pushed a commit to prasadkatti/ansible that referenced this pull request Oct 1, 2017
@willthames
Fix broken LimitExceeded check in iam_managed_policy (ansible#30537)
3e9edc6 
When policy versions exceed 5, we hit LimitExceeded. However,
the exception checking should use `e.response['Error']['Code']`
BondAnthony pushed a commit to BondAnthony/ansible that referenced this pull request Oct 5, 2017
@willthames @BondAnthony
Fix broken LimitExceeded check in iam_managed_policy (ansible#30537)
ec1587c 
When policy versions exceed 5, we hit LimitExceeded. However,
the exception checking should use `e.response['Error']['Code']`
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@s-hertel s-hertel s-hertel approved these changes

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 aws bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@willthames @ansibot @s-hertel @bcoca