Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This module allows users to manage partitions on a BIG-IP #30577

Merged

Conversation

caphrim007
Copy link
Contributor

SUMMARY

Adds module which allows users to manage partitions on a BIG-IP

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

lib/ansible/modules/network/f5/bigip_partition.py

ANSIBLE VERSION
ansible 2.5.0
  config file = None
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python2.7/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 2.7.14 (default, Sep 18 2017, 20:47:33) [GCC 4.9.2]
ADDITIONAL INFORMATION
  • Unit tests included
  • Functional tests included

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. labels Sep 19, 2017
@caphrim007
Copy link
Contributor Author

@gundalow ready for review

@ansibot
Copy link
Contributor

ansibot commented Sep 19, 2017

@Etienne-Carriere @caphrim007 @mhite @mryanlam @perzizzle @srvg @wojtek0806

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@gundalow gundalow removed the needs_triage Needs a first human triage before being processed. label Sep 20, 2017
@gundalow
Copy link
Contributor

Do we have the ability to run bigip integration tests in shippable?

@caphrim007
Copy link
Contributor Author

No, I was just including them for completeness. Should I remove them?

@gundalow
Copy link
Contributor

@caphrim007 You can remove them as they are in your repo and run by you.

@caphrim007
Copy link
Contributor Author

@gundalow, there are functional tests for configsync actions as well. remove those?

@gundalow
Copy link
Contributor

Keep the unit tests as we can run them via Shippable.

test/integration/targets is for tests at can run via Shippable.

Even when we move to using DCI (Distributed CI) we will need able to run integration tests from the F5Networks repo.

@caphrim007 caphrim007 force-pushed the feature.add-bigip-partition-module branch from a477591 to 255b84b Compare September 20, 2017 22:13
@caphrim007
Copy link
Contributor Author

@gundalow ok, pushed changes. waiting for shippable to finish. then ready for review

@gundalow gundalow merged commit 0eb0d96 into ansible:devel Sep 21, 2017
@gundalow
Copy link
Contributor

Merged into devel, will be releases in 2.5.0

@dagwieers dagwieers added the f5 label Sep 27, 2017
prasadkatti pushed a commit to prasadkatti/ansible that referenced this pull request Oct 1, 2017
BondAnthony pushed a commit to BondAnthony/ansible that referenced this pull request Oct 5, 2017
@caphrim007 caphrim007 deleted the feature.add-bigip-partition-module branch August 28, 2018 17:11
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.5 This issue/PR affects Ansible v2.5 community_review In order to be merged, this PR must follow the community review workflow. f5 module This issue/PR relates to a module. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants