Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] issue #29886 - docker_container module : take care about oom_killer (missed in host_config_params) #30712

Merged
merged 1 commit into from
Sep 26, 2017
Merged

[fix] issue #29886 - docker_container module : take care about oom_killer (missed in host_config_params) #30712

merged 1 commit into from
Sep 26, 2017

Conversation

dj4ngo
Copy link
Contributor

@dj4ngo dj4ngo commented Sep 21, 2017

SUMMARY

[fix] issue #29886 - it misses oom_killer in host_config_params
so it was never passed to docker API.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
ANSIBLE VERSION
ansible 2.5.0 (fix_issue_#29886_docker_oomkiller 86ab721629) last updated 2017/09/21 18:41:43 (GMT +200)

@ansibot
Copy link
Contributor

ansibot commented Sep 21, 2017

cc @cove @dusdanig @jctanner @kassiansun @softzilla @zfil
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request cloud community_review In order to be merged, this PR must follow the community review workflow. docker module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Sep 21, 2017
@mscherer mscherer removed the needs_triage Needs a first human triage before being processed. label Sep 22, 2017
@dj4ngo dj4ngo changed the title [fix] issue #29886 - it misses oom_killer in host_config_params [fix] issue #29886 - apt module : take care about oom_killer (missed in host_config_params) Sep 24, 2017
@dj4ngo dj4ngo changed the title [fix] issue #29886 - apt module : take care about oom_killer (missed in host_config_params) [fix] issue #29886 - docker_container module : take care about oom_killer (missed in host_config_params) Sep 24, 2017
@mscherer
Copy link
Contributor

shipit

kassiansun
kassiansun approved these changes Sep 26, 2017
View reviewed changes
Copy link
Contributor

@kassiansun kassiansun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Sep 26, 2017
@ansibot ansibot merged commit cb5f2c7 into ansible:devel Sep 26, 2017
prasadkatti pushed a commit to prasadkatti/ansible that referenced this pull request Oct 1, 2017
@dj4ngo
[fix] issue ansible#29886 - it misses oom_killer in host_config_params (
512af70 
ansible#30712)

so it was never passed to docker API.
BondAnthony pushed a commit to BondAnthony/ansible that referenced this pull request Oct 5, 2017
@dj4ngo @BondAnthony
[fix] issue ansible#29886 - it misses oom_killer in host_config_params (
6750fd7 
ansible#30712)

so it was never passed to docker API.
@chouseknecht chouseknecht mentioned this pull request Oct 6, 2017
Closed
@PikachuEXE PikachuEXE mentioned this pull request Dec 21, 2017
Merged
abadger pushed a commit that referenced this pull request Feb 15, 2018
@PikachuEXE @abadger
Backport fix in PR #30712 into 2.4
14e7432 
#30712
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kassiansun kassiansun kassiansun approved these changes

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. cloud docker module This issue/PR relates to a module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dj4ngo @ansibot @mscherer @kassiansun