Fix for #3062 additional groups should only be added once. #3072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also consolidated duplicate groups code into one get_groups_set() method. Removed unused call to user_group_membership. Removed sorting operations on set functions cause sets are inherently unordered. Minor style improvements to match the rest of the code. The new function will make the order of group names passed to the system command less determistic. Which was already the case for modify_user_usermod() but not for other methods. It will also strip out duplicate group names automatically which was not always the case previously.
|
in queue for testing, thanks! As this is the groups module and affects lots of OSes and such, I may ask some folks in IRC to also help test. |
|
merged, thanks! removed one stray debug statement about xxx.log |
|
yeah found that one.. sorry that it found it's way into the pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also consolidated duplicate groups code into one get_groups_set() method.
Removed unused call to user_group_membership.
Removed sorting operations on set functions cause sets are inherently unordered.
Minor style improvements to match the rest of the code.
The new function will make the order of group names passed to the system command less determistic.
Which was already the case for modify_user_usermod() but not for other methods.
It will also strip out duplicate group names automatically which was not always the case previously.