Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to aruba terminal plugin #30994

Merged
merged 1 commit into from
Sep 28, 2017
Merged

Conversation

jmighion
Copy link
Member

SUMMARY

Adding new stdout regex to allow local password changes. Adding stderr regex to catch more errors.

The command to update the management user mgmt-user <username> <rolename> leaves you on prompts Password: and Re-Type password:. Those needed to be treated as a valid stdout prompt to continue. If the passwords entered did not match the error is Error: Passwords don't match Try again. Catching that with new stderr regex.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

aruba.py terminal plugin

ANSIBLE VERSION
--version
ansible 2.5.0 (aruba_terminal 5caa0347dd) last updated 2017/09/27 08:50:41 (GMT -700)
  config file = None
  configured module search path = [u'/Users/james/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/james/Documents/git/ansible/lib/ansible
  executable location = /Users/james/Documents/git/ansible/bin/ansible
  python version = 2.7.13 (default, Jul 18 2017, 09:17:00) [GCC 4.2.1 Compatible Apple LLVM 8.1.0 (clang-802.0.42)]

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request needs_triage Needs a first human triage before being processed. networking Network category plugins/terminal support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 27, 2017
@jborean93
Copy link
Contributor

cc @jmighion

@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Sep 28, 2017
@jmighion
Copy link
Member Author

@jborean93 I submitted this. Why the cc?

@jborean93
Copy link
Contributor

Sorry I was on autopilot, please ignore me.

Copy link
Member

@ganeshrn ganeshrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ganeshrn ganeshrn merged commit 2837200 into ansible:devel Sep 28, 2017
prasadkatti pushed a commit to prasadkatti/ansible that referenced this pull request Oct 1, 2017
BondAnthony pushed a commit to BondAnthony/ansible that referenced this pull request Oct 5, 2017
@jmighion jmighion deleted the aruba_terminal branch November 2, 2017 18:46
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. networking Network category plugins/terminal support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants