Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor fix in docs for gce_backend_service examples #31134

Merged
merged 1 commit into from
Sep 13, 2018
Merged

minor fix in docs for gce_backend_service examples #31134

merged 1 commit into from
Sep 13, 2018

Conversation

vibhavsinha
Copy link
Contributor

SUMMARY

gce_backend_service module expects healthchecks to be an array of string. The previous example incorrectly mentioned healthchecks as an array of objects each containing a name key.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

gce_backend_service

ANSIBLE VERSION
2.4.0.0
ADDITIONAL INFORMATION

Error when using the given examples

libcloud.common.google.InvalidRequestError: {u'locationType': u'parameter', u'domain': u'global', u'message': u"Invalid value '{'name': 'sample1-healthcheck'}'. Values must match the followi
ng regular expression: '[a-z](?:[-a-z0-9]{0,61}[a-z0-9])?'", u'reason': u'invalidParameter', u'location': u'httpHealthCheck'}

@vibhavsinha
fix gce_backend_service examples for healthchecks
a772e9e 
gce_backend_service module expects healthchecks to be an array of string. The previous example incorrectly mentioned healthchecks as an array of objects each containing a `name` key.
@ansibot
Copy link
Contributor

ansibot commented Sep 30, 2017

cc @erjohnso @supertom
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 cloud community_review In order to be merged, this PR must follow the community review workflow. docs_pull_request gce module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Sep 30, 2017
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Oct 2, 2017
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 10, 2017
@ansibot ansibot added the new_contributor This PR is the first contribution by a new community member. label Oct 18, 2017
@ansibot ansibot removed the new_contributor This PR is the first contribution by a new community member. label Nov 3, 2017
@ansibot
Copy link
Contributor

ansibot commented Jan 6, 2018

cc @rambleraptor
click here for bot help

@ansibot ansibot added the new_contributor This PR is the first contribution by a new community member. label Feb 6, 2018
@ansibot ansibot added docs This issue/PR relates to or includes documentation. and removed docs_pull_request labels Mar 1, 2018
@acozine
Copy link
Contributor

acozine commented Sep 13, 2018

Thanks @vibhavsinha for improving the documentation. We appreciate your attention to detail and your support of Ansible!

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 13, 2018
@acozine acozine merged commit e26d758 into ansible:devel Sep 13, 2018
@acozine acozine added this to To do in OLD Ansible Documentation via automation Sep 13, 2018
@acozine acozine moved this from To do to Backport to 2.7 in OLD Ansible Documentation Sep 17, 2018
samccann pushed a commit to samccann/ansible that referenced this pull request Sep 20, 2018
@vibhavsinha @samccann
fix gce_backend_service examples for healthchecks (ansible#31134)
db6e47b 
gce_backend_service module expects healthchecks to be an array of string. The previous example incorrectly mentioned healthchecks as an array of objects each containing a `name` key.
(cherry picked from commit e26d758)
@samccann samccann mentioned this pull request Sep 20, 2018
Merged
acozine pushed a commit that referenced this pull request Sep 20, 2018
@samccann @acozine
[WIP] Backport/2.7/second batch (#45927)
0c81145 
* Update influxdb_database.py (#39984)
(cherry picked from commit 049a462)

* Link to the Galaxy platforms list from the meta file template (#34046)
(cherry picked from commit fa18d45)

* fix gce_backend_service examples for healthchecks (#31134)
(cherry picked from commit e26d758)

* Clarify the creates and removes options (#45485)
(cherry picked from commit bf90a44)

* lineinfile note belongs in changelog for 2.6, not 2.7 (#45517)
(cherry picked from commit 228fee4)

* Update keycloak_client.py (#43547)
(cherry picked from commit cb460de)

* The keyword 'cloud' has been deprecated in favor of the 'profile' keyword by os-client-config. (#31389)
(cherry picked from commit 17ca0a9)

* Clarified documentation for the unsafe_writes option (#27471)
(cherry picked from commit dd5d191)
@acozine acozine moved this from Backport to 2.7 to Done in OLD Ansible Documentation Sep 20, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryansb ryansb ryansb approved these changes

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 cloud community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. gce module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
No open projects
OLD Ansible Documentation
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vibhavsinha @ansibot @acozine @ryansb @bcoca