Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable 'test' label for test related pull requests #31472

Merged
merged 2 commits into from
Oct 17, 2017
Merged

Reenable 'test' label for test related pull requests #31472

merged 2 commits into from
Oct 17, 2017

Conversation

pilou-
Copy link
Contributor

@pilou- pilou- commented Oct 9, 2017

SUMMARY

Reenable test label for test related pull requests

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

.github/BOTMETA.yml

ANSIBLE VERSION
2.5.0
ADDITIONAL INFORMATION

See:

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 feature_pull_request needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 9, 2017
@bcoca
Copy link
Member

bcoca commented Oct 9, 2017

@pilou- I believe you want test_pull_requests instead, we don't really want multiple labels for the same thing.

cc @mattclay to correct me if im wrong.

@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Oct 9, 2017
@pilou-
Copy link
Contributor Author

pilou- commented Oct 9, 2017

I agree, we don't want multiple labels for the same thing :)
test label was chosen, see ansible/ansibullbot#764 (comment).

@bcoca
Copy link
Member

bcoca commented Oct 9, 2017

^ we had discussion in core meeting which iirc ended up in the reverse of that ticket.

Also we might want to add 'test issues' in the future for reporting bugs with tests and keep the parity with features & bugs.

@pilou-
Copy link
Contributor Author

pilou- commented Oct 9, 2017

Then is:pr label:test or is:issue label:test could be used, one label could be used on issues and pull requests, that's not a problem.

ping @gundalow

@mattclay
Copy link
Member

mattclay commented Oct 9, 2017

In the Testing Working Group we agreed to go with a single test label:

https://meetbot.fedoraproject.org/ansible-meeting/2017-10-05/testing_working_group.2017-10-05-17.00.html

I don't recall this being discussed in the core meeting.

@samdoran samdoran merged commit 2c5ce65 into ansible:devel Oct 17, 2017
@pilou- pilou- mentioned this pull request Oct 18, 2017
Closed
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 5, 2018
@pilou- pilou- mentioned this pull request Jun 22, 2018
Merged
@dagwieers dagwieers added the botmeta This PR modifies the BOTMETA.yml and this requires special attention! label Feb 21, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 botmeta This PR modifies the BOTMETA.yml and this requires special attention! feature This issue/PR relates to a feature request. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pilou- @bcoca @mattclay @dagwieers @samdoran @ansibot