Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: add #AnsibleRequires for Windows modules #31683

Merged
merged 5 commits into from
Oct 23, 2017

Conversation

jborean93
Copy link
Contributor

SUMMARY

This PR adds in the functionality to use #AnsibleRequires to state whether a module requires

  • to be run in become mode, bypassing WinRM restrictions like Windows Updates. If become: yes isn't set on this task then Ansible will become the SYSTEM account
  • The minimum OS version based on the major.minor. Useful for things like win_share that require a minimum OS version for it to work
  • The minimum PS version based on the major.minor, self explanatory

Once the format is done and this is merged in, I will create a separate PR to update the docs.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

windows

ANSIBLE VERSION
2.5

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 executor/module_common feature_pull_request needs_triage Needs a first human triage before being processed. plugins/shell support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 13, 2017
@jborean93 jborean93 added windows Windows community and removed needs_triage Needs a first human triage before being processed. labels Oct 13, 2017
@jhawkesworth
Copy link
Contributor

Nice feature.

If I recall win_firewall has a minimum PS version, but lets gets this in first.

Code looks good to me, seems low risk to merge now, relatively early in 2.5.

@ansibot ansibot added test This PR relates to tests. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 18, 2017
@ansibot ansibot added c:inventory/contrib_script cloud cloudstack docker docs_pull_request f5 inventory Inventory category merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html networking Network category openstack virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) vmware VMware community labels Oct 23, 2017
@ansible ansible deleted a comment from ansibot Oct 23, 2017
@ansible ansible deleted a comment from ansibot Oct 23, 2017
@nitzmahone nitzmahone removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 23, 2017
@nitzmahone
Copy link
Member

@jborean93 /me had a little booboo using "add commits" capability (accidentally tried to add a commit from a rebased branch w/o force-push). I think I've got it reassembled properly, but you might want to compare against your local copy if you still have it...

@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Oct 23, 2017
@jborean93
Copy link
Contributor Author

@nitzmahone looks like you fixed it up correctly.

@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Oct 23, 2017
@nitzmahone nitzmahone merged commit b004a63 into ansible:devel Oct 23, 2017
@jborean93 jborean93 deleted the win-module-become branch October 23, 2017 21:27
@dagwieers dagwieers removed c:inventory/contrib_script cloud cloudstack docker docs_pull_request f5 inventory Inventory category networking Network category openstack virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) vmware VMware community labels Oct 23, 2017
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 5, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.5 This issue/PR affects Ansible v2.5 executor/module_common feature This issue/PR relates to a feature request. plugins/shell support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. windows Windows community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants