Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow become methods for Jail connection plugin #31746

Merged
merged 2 commits into from
May 8, 2018

Conversation

slohse
Copy link
Contributor

@slohse slohse commented Oct 14, 2017

SUMMARY

This change allows all become methods for the jail connector. I personally only tested su, sudo and doas, but looking at the other connectors the general style seems to be to just allow all, potentially excluding ones that proved problematic.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

jail connection plugin

ANSIBLE VERSION
devel

- i personally tested 'su', 'sudo' and 'doas'
@ansibot
Copy link
Contributor

ansibot commented Oct 14, 2017

The test ansible-test sanity --test pylint [?] failed with the following error:

lib/ansible/plugins/connection/jail.py:62:31: undefined-variable Undefined variable 'C'

click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 ci_verified Changes made in this PR are causing tests to fail. feature_pull_request needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. plugins/connection support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 14, 2017
@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 14, 2017
@alikins alikins removed the needs_triage Needs a first human triage before being processed. label Oct 16, 2017
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 24, 2017
@slohse
Copy link
Contributor Author

slohse commented Jan 22, 2018

Is there anything I can do to help this PR along?

@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 2, 2018
@bcoca bcoca merged commit 1e4c389 into ansible:devel May 8, 2018
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 12, 2018
* allow become methods

- i personally tested 'su', 'sudo' and 'doas'

* forgot to import constants m(
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
* allow become methods

- i personally tested 'su', 'sudo' and 'doas'

* forgot to import constants m(
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
* allow become methods

- i personally tested 'su', 'sudo' and 'doas'

* forgot to import constants m(
tonal pushed a commit to tonal/ansible that referenced this pull request May 15, 2018
* allow become methods

- i personally tested 'su', 'sudo' and 'doas'

* forgot to import constants m(
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
* allow become methods

- i personally tested 'su', 'sudo' and 'doas'

* forgot to import constants m(
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
* allow become methods

- i personally tested 'su', 'sudo' and 'doas'

* forgot to import constants m(
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
* allow become methods

- i personally tested 'su', 'sudo' and 'doas'

* forgot to import constants m(
@dagwieers dagwieers removed bsd BSD community labels Jan 18, 2019
@dagwieers dagwieers added the bsd BSD community label Jan 18, 2019
@ansible ansible locked and limited conversation to collaborators May 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bsd BSD community feature This issue/PR relates to a feature request. plugins/connection stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants