-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow become methods for Jail connection plugin #31746
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- i personally tested 'su', 'sudo' and 'doas'
The test
|
ansibot
added
affects_2.5
This issue/PR affects Ansible v2.5
ci_verified
Changes made in this PR are causing tests to fail.
feature_pull_request
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
needs_triage
Needs a first human triage before being processed.
plugins/connection
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
labels
Oct 14, 2017
ansibot
removed
ci_verified
Changes made in this PR are causing tests to fail.
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
labels
Oct 14, 2017
alikins
removed
the
needs_triage
Needs a first human triage before being processed.
label
Oct 16, 2017
ansibot
added
the
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
label
Oct 24, 2017
Is there anything I can do to help this PR along? |
ansibot
added
feature
This issue/PR relates to a feature request.
and removed
feature_pull_request
labels
Mar 2, 2018
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 12, 2018
* allow become methods - i personally tested 'su', 'sudo' and 'doas' * forgot to import constants m(
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 14, 2018
* allow become methods - i personally tested 'su', 'sudo' and 'doas' * forgot to import constants m(
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 14, 2018
* allow become methods - i personally tested 'su', 'sudo' and 'doas' * forgot to import constants m(
tonal
pushed a commit
to tonal/ansible
that referenced
this pull request
May 15, 2018
* allow become methods - i personally tested 'su', 'sudo' and 'doas' * forgot to import constants m(
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 15, 2018
* allow become methods - i personally tested 'su', 'sudo' and 'doas' * forgot to import constants m(
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 15, 2018
* allow become methods - i personally tested 'su', 'sudo' and 'doas' * forgot to import constants m(
ilicmilan
pushed a commit
to ilicmilan/ansible
that referenced
this pull request
Nov 7, 2018
* allow become methods - i personally tested 'su', 'sudo' and 'doas' * forgot to import constants m(
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects_2.5
This issue/PR affects Ansible v2.5
bsd
BSD community
feature
This issue/PR relates to a feature request.
plugins/connection
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This change allows all become methods for the jail connector. I personally only tested
su
,sudo
anddoas
, but looking at the other connectors the general style seems to be to just allow all, potentially excluding ones that proved problematic.ISSUE TYPE
COMPONENT NAME
jail connection plugin
ANSIBLE VERSION