Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up cloudformation examples #31770

Merged
merged 1 commit into from
Oct 16, 2017
Merged

Clean up cloudformation examples #31770

merged 1 commit into from
Oct 16, 2017

Conversation

prasadkatti
Copy link
Contributor

SUMMARY
  • added role_arn to the "role example" example
  • removed the irrelevant parameters to the "role example" example
  • updated comment on one of the examples
  • removed the last example as it was a duplicate of "role example" example
  • some other minor changes
ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

cloudformation

ANSIBLE VERSION
ansible 2.5.0

@prasadkatti
Clean up the cloudformation examples
df7943a 
- added `role_arn` to the "role example" example
- removed the irrelevant parameters to the "role example" example
- updated comment on one of the examples
- removed the last example as it was a duplicate of "role example" example
- some other minor changes
@ansibot
Copy link
Contributor

ansibot commented Oct 16, 2017

cc @jsmartin @ryansb @tedder
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 aws cloud core_review In order to be merged, this PR must follow the core review workflow. docs_pull_request module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 16, 2017
@tedder
Copy link
Contributor

tedder commented Oct 16, 2017

Make sense. shipit

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Oct 16, 2017
@ryansb ryansb merged commit 30fd187 into ansible:devel Oct 16, 2017
@prasadkatti prasadkatti deleted the cft_examples branch October 16, 2017 16:00
@ansibot ansibot added docs This issue/PR relates to or includes documentation. and removed docs_pull_request labels Mar 4, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryansb ryansb ryansb approved these changes

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 aws cloud core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@prasadkatti @ansibot @tedder @ryansb