Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move zabbix_*-modules commonly used doc fragments to central place #31833

Merged
merged 2 commits into from
Oct 17, 2017

Conversation

eikef
Copy link
Contributor

@eikef eikef commented Oct 17, 2017

SUMMARY

In zabbix_host, zabbix_hostmacro, zabbix_screen, zabbix_maintenance, and zabbix_group the parameters server_url, login_user, login_password, http_login_user, http_login_password, and timeout are the exact same. Since a centralized module_doc_fragment exists now, this PR moves the documentation for them there to reduce duplication and ease further maintenance.

There is one zabbix_-module missing from this list (zabbix_template). Once this PR is in, there will be a new PR for that one since it also needs implementation of validate_certs in order to use that module_doc_fragment.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

zabbix_*

ANSIBLE VERSION

2.5.0

@ansibot
Copy link
Contributor

ansibot commented Oct 17, 2017

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 community_review In order to be merged, this PR must follow the community review workflow. docs_pull_request module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Oct 17, 2017
@resmo
Copy link
Contributor

resmo commented Oct 17, 2017

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Oct 17, 2017
@D3DeFi
Copy link
Contributor

D3DeFi commented Oct 17, 2017

shipit

@resmo resmo merged commit 0a89873 into ansible:devel Oct 17, 2017
@eikef eikef deleted the centralize_zabbix_doc_fragment branch October 17, 2017 22:57
@ansibot ansibot added docs This issue/PR relates to or includes documentation. and removed docs_pull_request labels Mar 4, 2018
@dagwieers dagwieers added the zabbix Zabbix community label Jan 28, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.5 This issue/PR affects Ansible v2.5 docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. zabbix Zabbix community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants