ec2_vpc_subnet retries #31870
Merged
ec2_vpc_subnet retries #31870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 18, 2017 17:03
Improve exception handling to latest standards
ansibot
added
affects_2.5
gundalow
removed
the
needs_triage
This was referenced Oct 18, 2017
Fix bug identified by test Fixes ansible#31905
s-hertel
approved these changes
Oct 19, 2017
|
|
||
| to_delete = dict((k, cur_tags[k]) for k in cur_tags if k not in tags) | ||
| if to_delete and not add_only and not check_mode: | ||
| to_delete = dict((k, cur_tags[k]) for k in cur_tags if k not in tags) |
There was a problem hiding this comment.
Can you use compare_aws_tags() for this?
There was a problem hiding this comment.
@s-hertel this is mostly an indentation change.
You're quite right, but that would make this change 'bigger'
ansibot
added
the
stale_ci
|
rebuild_merge |
ansibot
removed
the
stale_ci
ansibot
added
the
stale_ci
|
rebuild_merge |
ansibot
removed
the
stale_ci
ryansb
approved these changes
Nov 16, 2017
ryansb
pushed a commit
that referenced
this pull request
Nov 16, 2017
* Add integration test suite for ec2_vpc_subnet * wrap boto3 connection in try/except update module documentation and add RETURN docs add IPv6 support to VPC subnet module rename ipv6cidr to ipv6_cidr, use required_if for parameter testing, update some failure messages to be more descriptive DryRun mode was removed from this function a while ago but exception handling was still checking for it, removed add wait and timeout for subnet creation process fixup the ipv6 cidr disassociation logic a bit per review update RETURN values per review added module parameter check removed DryRun parameter from boto3 call since it would always be false here fix subnet wait loop add a purge_tags parameter, fix the ensure_tags function, update to use compare_aws_tags func fix tags type error per review remove **kwargs use in create_subnet function per review * rebased on #31870, fixed merge conflicts, and updated error messages * fixes to pass tests * add test for failure on invalid ipv6 block and update tags test for purge_tags=true function * fix pylint issue * fix exception handling error when run with python3 * add ipv6 tests and fix module code * Add permissions to hacking/aws_config/testing_policies/ec2-policy.json for adding IPv6 cidr blocks to VPC and subnets * fix type in tests and update assert conditional to check entire returned value * add AWS_SESSION_TOKEN into environment for aws cli commands to work in CI * remove key and value options from call to boto3_tag_list_to_ansible_dict * remove wait loop and use boto3 EC2 waiter * remove unused register: result vars * revert az argument default value to original setting default=None
ansibot
added
feature
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Improve ec2_vpc_subnet retry and exception handling
Add integration test suite
ISSUE TYPE
COMPONENT NAME
ec2_vpc_subnet
ANSIBLE VERSION