Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ovirt_host_networks: Fix label assignment #31969

Merged
merged 1 commit into from
Oct 20, 2017
Merged

ovirt_host_networks: Fix label assignment #31969

merged 1 commit into from
Oct 20, 2017

Conversation

machacekondra
Copy link
Contributor

SUMMARY

This PR fixes the label assigment on network interface or bond.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ovirt_host_networks

ANSIBLE VERSION
2.3.2
ADDITIONAL INFORMATION

Now user can assign labels to interface, by executing following task, previously just network assignment worked and was checked:

- name: Assign VLAN to eth1 on host1
    ovirt_host_networks:
      auth: "{{ ovirt_auth }}"
      name: host1
      interface: eth1
      labels:
        - INT
        - PRD
      save: true
      check: true

@ansibot
Copy link
Contributor

ansibot commented Oct 20, 2017

cc @mwperina
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Oct 20, 2017
@machacekondra machacekondra mentioned this pull request Oct 20, 2017
Open
mwperina
mwperina approved these changes Oct 20, 2017
View reviewed changes
Copy link
Contributor

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Oct 20, 2017
@ansibot ansibot merged commit d6b5649 into ansible:devel Oct 20, 2017
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@machacekondra machacekondra deleted the fix_network_label_assignment branch August 15, 2018 10:43
@dagwieers dagwieers added the ovirt oVirt and RHV community label Feb 20, 2019
@dagwieers dagwieers removed virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) labels Feb 28, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mwperina mwperina mwperina approved these changes

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. ovirt oVirt and RHV community owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@machacekondra @ansibot @mwperina @dagwieers