Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segment out the update method #32103

Merged
merged 1 commit into from
Oct 24, 2017
Merged

Segment out the update method #32103

merged 1 commit into from
Oct 24, 2017

Conversation

caphrim007
Copy link
Contributor

SUMMARY

This patch changes the base parameters class to segment out the
update method. This is done often throughout the f5 modules, so
this just bakes it into the mod utils so that I can delete it
from each module

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

f5_utils.py

ANSIBLE VERSION
ansible 2.5.0
  config file = None
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python2.7/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 2.7.14 (default, Oct 10 2017, 02:49:49) [GCC 4.9.2]
ADDITIONAL INFORMATION

@caphrim007
Segment out the update method
657c6c5 
This patch changes the base parameters class to segment out the
update method. This is done often throughout the f5 modules, so
this just bakes it into the mod utils so that I can delete it
from each module
@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request f5 module_utils/ needs_triage Needs a first human triage before being processed. networking Network category owner_pr This PR is made by the module's maintainer. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 24, 2017
@caphrim007 caphrim007 merged commit d067166 into ansible:devel Oct 24, 2017
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Oct 26, 2017
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@caphrim007 caphrim007 deleted the breakout-code-for-f5-parameters branch August 28, 2018 17:11
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. f5 module_utils/ networking Network category owner_pr This PR is made by the module's maintainer. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@caphrim007 @samdoran @ansibot