Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ec2_lc failing to create multi-volume configurations #32163

Merged
merged 1 commit into from
Oct 26, 2017
Merged

Fix ec2_lc failing to create multi-volume configurations #32163

merged 1 commit into from
Oct 26, 2017

Conversation

awkspace
Copy link
Contributor

SUMMARY

This pull request fixes an issue with ec2_lc where a configuration with multiple volumes would create a launch config with only one volume.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_lc

ANSIBLE VERSION
ansible 2.5.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/chris/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python2.7/dist-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 2.7.13 (default, Jan 19 2017, 14:48:08) [GCC 6.3.0 20170118]

@ansibot
Copy link
Contributor

ansibot commented Oct 25, 2017

cc @garethr @wilvk
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 aws bugfix_pull_request cloud committer_review In order to be merged, this PR must follow the certified review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:certified This issue/PR relates to certified code. labels Oct 25, 2017
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Oct 25, 2017
@willthames
Copy link
Contributor

Tested by me by running in an LC with two block devices. Only one showed up before change, both showed up after.

@willthames willthames merged commit 87989b5 into ansible:devel Oct 26, 2017
@willthames
Copy link
Contributor

Thanks very much @awkspace

@willthames
Copy link
Contributor

If you'd like this backported to 2.4, can you raise the same PR against stable-2.4 branch?

@awkspace awkspace mentioned this pull request Oct 26, 2017
Merged
@awkspace
Copy link
Contributor Author

@willthames Sure! Opened PR #32191.

@willthames willthames mentioned this pull request Dec 4, 2017
Closed
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 aws bug This issue/PR relates to a bug. cloud committer_review In order to be merged, this PR must follow the certified review workflow. module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. support:certified This issue/PR relates to certified code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@awkspace @ansibot @willthames @jborean93