Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add final block to list of blocks. #32172

Merged
merged 1 commit into from
Nov 1, 2017
Merged

Add final block to list of blocks. #32172

merged 1 commit into from
Nov 1, 2017

Conversation

jmighion
Copy link
Member

SUMMARY

The last sections of lines that make up a block to search through were left behind. This change fixes that.
The list of lines doesn't get appended to the list of blocks until a new block is found. Changing that to append to the list of blocks when the end of the block is found.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

parse_cli filter

ANSIBLE VERSION
ansible 2.5.0 (parse_cli_blocks 8144f44229) last updated 2017/10/25 14:34:16 (GMT -700)
  config file = /Users/james/Documents/Microsoft/git/Ansible-Networking/ansible.cfg
  configured module search path = [u'/Users/james/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/james/Documents/git/ansible/lib/ansible
  executable location = /Users/james/Documents/git/ansible/bin/ansible
  python version = 2.7.13 (default, Jul 18 2017, 09:17:00) [GCC 4.2.1 Compatible Apple LLVM 8.1.0 (clang-802.0.42)]

@ansibot
Copy link
Contributor

ansibot commented Oct 25, 2017

cc @Qalthos @ganeshrn @gundalow @kedarX @privateip @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request needs_triage Needs a first human triage before being processed. networking Network category plugins/filter support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 25, 2017
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Oct 25, 2017
@jmighion jmighion mentioned this pull request Oct 31, 2017
Closed
@gundalow gundalow added this to the 2.5.0 milestone Nov 1, 2017
@gundalow
Copy link
Contributor

gundalow commented Nov 1, 2017

So rule is new network functionality must be tested, though this is a bug fix, so I'm accepting for this PR to be merged without tests, currently we have no tests in https://github.com/ansible/ansible/tree/devel/test/units/plugins/filter for network.py

ganeshrn
ganeshrn approved these changes Nov 1, 2017
View reviewed changes
Copy link
Member

@ganeshrn ganeshrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ganeshrn ganeshrn merged commit 93c965f into ansible:devel Nov 1, 2017
@ganeshrn
Copy link
Member

ganeshrn commented Nov 1, 2017

@jmighion Thank you

@bcoca bcoca added this to Nominated in 2.4.x Blocker List Nov 1, 2017
@abadger
Copy link
Contributor

abadger commented Nov 1, 2017

this has been cherry-picked for 2.4.2beta2

@abadger abadger moved this from Nominated to Done in 2.4.2 in 2.4.x Blocker List Nov 1, 2017
@jmighion jmighion deleted the parse_cli_blocks branch November 2, 2017 18:45
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ganeshrn ganeshrn ganeshrn approved these changes

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. networking Network category plugins/filter support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
No open projects
2.4.x Blocker List
Done in 2.4.2
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jmighion @ansibot @gundalow @ganeshrn @abadger @jborean93