Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consul_kv: Doc fixes #32340

Merged
merged 1 commit into from
Nov 1, 2017
Merged

consul_kv: Doc fixes #32340

merged 1 commit into from
Nov 1, 2017

Conversation

dagwieers
Copy link
Contributor

@dagwieers dagwieers commented Oct 30, 2017 •
edited

SUMMARY

This PR includes:

  • PEP8 compliancy
  • Doc fixes
ISSUE TYPE
  • Feature Pull Request
  • Docs Pull Request
COMPONENT NAME

consul_kv

ANSIBLE VERSION

v2.5

@ansibot
Copy link
Contributor

ansibot commented Oct 30, 2017

cc @sgargan
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 community_review In order to be merged, this PR must follow the community review workflow. feature_pull_request module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Oct 30, 2017
@ansible ansible deleted a comment from ansibot Oct 30, 2017
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed ci_verified Changes made in this PR are causing tests to fail. labels Oct 30, 2017
@dagwieers
consul_kv: PEP8 compliancy and doc fixes
8ac71e6 
This PR includes:
- PEP8 compliancy
- Doc fixes
@dagwieers dagwieers changed the title consul_kv: PEP8 compliancy and doc fixes consul_kv: Doc fixes Oct 30, 2017
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 30, 2017
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Oct 30, 2017
Akasurde
Akasurde approved these changes Nov 1, 2017
View reviewed changes
Copy link
Member

@Akasurde Akasurde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Nov 1, 2017
@ansibot ansibot merged commit a1d6074 into ansible:devel Nov 1, 2017
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 5, 2018
@freeseacher freeseacher mentioned this pull request Mar 8, 2018
Closed
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Akasurde Akasurde Akasurde approved these changes

@daxlab daxlab daxlab approved these changes

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 automerge This PR was automatically merged by ansibot. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dagwieers @ansibot @Akasurde @daxlab @bcoca